Merge pull request #927 from jitsi/fix-feedback-resolve

Makes sure we always resolve(call the callback) in feedback dialog.
2016-09-22 17:47:17 -05:00
parent 06247266ad eb2e709749
commit 5ef241ae66
1 changed files with 7 additions and 5 deletions
@@ -176,6 +176,13 @@ export default class Dialog {
        });
        this.$el = this.window.$el;

+        AJS.dialog2(selector).on("hide", function() {
+            if (this.onCloseCallback) {
+                this.onCloseCallback();
+                this.onCloseCallback = null;
+            }
+        }.bind(this));
+
        this.setState();
    }

@@ -201,11 +208,6 @@ export default class Dialog {

    hide() {
        this.window.hide();
-
-        if (this.onCloseCallback) {
-            this.onCloseCallback();
-            this.onCloseCallback = null;
-        }
    }

    onFeedbackSubmitted() {