Michael Rash
f95901ac03
[test suite] minor tests directory path update
2018-08-17 18:41:57 -07:00
Michael Rash
02542a025e
[test suite] minor update to exercise rc file comment line detection code
2018-08-11 09:46:22 -07:00
Michael Rash
799ec87765
[client] write --server-resolve-ipv4 arg to the rc file when saving
2018-08-11 09:42:20 -07:00
Michael Rash
5339179c8e
[test suite] NO_SAVE_ARGS rc file code coverage
2018-08-11 08:43:47 -07:00
Michael Rash
69291b91fa
[test suite] add invalid ALLOW_IP test
2018-08-11 08:23:41 -07:00
Michael Rash
40d554103c
[test suite] add negative time offset test to hit additional error path in client/config_init.c
2018-08-11 08:15:26 -07:00
Michael Rash
759965ee08
[server] fix UBSAN warning 'fwknopd.c:1044:50: runtime error: left shift of 2 by 30 places cannot be represented in type 'int''
2018-08-10 21:22:23 -07:00
Michael Rash
a7fc73b111
[test suite] start with -m32 gcc option for ASAN instrumentation check (32-bit compilation is preferred for ASAN operations)
2018-08-10 18:33:54 -07:00
Michael Rash
ffa6548946
[test suite] add --enable-cunit-tests to -h output
2018-08-10 18:32:26 -07:00
Michael Rash
0b9639f29a
[test suite] restore C-Unit test functionality (header ordering fix)
2018-08-10 09:21:13 -07:00
Michael Rash
be142216e4
[test suite] remove redundant statement
2018-08-10 08:54:07 -07:00
Michael Rash
9bdaf393bf
better ASAN instrumention check using readelf
2018-08-10 08:27:15 -07:00
Michael Rash
5a305ffe07
[test suite] improve ASAN instrumentation check (m32 vs. non-m32 Makefile option)
2018-08-10 07:44:10 -07:00
Michael Rash
6438771965
Merge pull request #273 from DeforaNetworks/khorben/http-1.1
...
Use HTTP/1.1 when communicating over HTTP
2018-08-09 04:51:45 -07:00
Michael Rash
71b8f22402
Merge pull request #282 from DeforaNetworks/khorben/execvp
...
Use execvp() instead of execvpe()
2018-08-08 17:05:55 -07:00
Michael Rash
d59c77a20b
Revert "Fix two erroneous calls to strlcat()"
...
This reverts commit c412166aaa
2018-08-07 23:35:34 -07:00
Michael Rash
c4f437f1dc
Merge pull request #284 from DeforaNetworks/khorben/strlcat
2018-08-07 06:28:12 -04:00
khorben
c412166aaa
Fix two erroneous calls to strlcat()
...
strlcat() needs to be informed about the actual size of the buffer. Two
calls simply used the size expected, thus potentially allowing
stack-based buffer overflows.
There is no direct security impact in this case, since the code affected
is on the client side, and the input comes from configuration
information.
2018-08-07 09:48:30 +02:00
Michael Rash
108290c6f3
Merge pull request #283 from DeforaNetworks/khorben/srandom
...
Seed random() at least a bit before using random()
2018-08-06 20:49:49 -04:00
Michael Rash
2766648afd
Merge branch 'master' of ssh://ubuntu1604/home/mbr/git/fwknop
2018-08-06 20:43:29 -04:00
Michael Rash
d8b9005d19
Merge branch 'master' of https://github.com/mrash/fwknop
2018-08-06 17:41:32 -07:00
Michael Rash
a6337ba054
Merge branch 'master' of ssh://github.com/mrash/fwknop
2018-08-06 20:41:09 -04:00
Michael Rash
bd30379313
doc update
2018-08-06 17:27:52 -07:00
Michael Rash
81a264ad24
bump version to 2.6.10
2018-08-06 17:26:12 -07:00
Michael Rash
b15b278263
add erlang files
2018-08-06 17:24:03 -07:00
Michael Rash
e191e494a0
minor documentation update
2018-08-06 16:52:05 -07:00
khorben
f00d44deac
Seed random() at least a bit before using random()
...
In fwknop, the values generated using random() are only used for the ID
field of raw IP packets. As indicated in the corresponding comments,
this value does not really matter, and it does not really have to be
random at all.
However, it should not hurt to initialize the entropy pool before
generating random values. arc4random() would be a better choice, but it
is not portable across the range of systems currently supported by
fwknop.
2018-08-06 19:20:35 +02:00
khorben
0b475ec7b3
Use execvp() instead of execvpe()
...
execvp() is (usually) equivalent to execvpe(), without enforcing any
change to the environment. However, unlike execvp(), execvpe() is not
standardized by POSIX, and may therefore not be available nor detected
when configuring the project (like on NetBSD).
No place could be found in fwknop to be using execvpe() and changing the
environment. Therefore it seems only logical (and safer) to use execvp()
instead.
This also updates the tests to reflect this change.
2018-08-06 12:04:45 +02:00
Michael Rash
ae089b1bad
Merge pull request #280 from DeforaNetworks/khorben/connect-error-format
2018-07-25 18:42:29 -04:00
khorben
6d6a722128
Fix incomplete format string upon errors
2018-07-25 22:35:03 +02:00
Michael Rash
e0c860d2c7
Merge pull request #277 from DeforaNetworks/khorben/usage
...
More consistent usage screens
2018-07-18 21:28:48 -04:00
khorben
8a1289cdc9
More consistent usage screens
2018-07-17 16:45:46 +02:00
Michael Rash
b4c75d195f
Merge pull request #274 from DeforaNetworks/khorben/typo
2018-07-11 22:36:40 -04:00
khorben
50f56a581f
Fix the configuration variable name for GPG_DECRYPT_PW
2018-07-10 11:31:54 +02:00
khorben
adada04a20
Use HTTP/1.1 when using HTTP proxies
...
The "Connection" and "Host" fields were already always provided anyway.
2018-07-09 14:16:06 +02:00
khorben
148d6eba22
Use HTTP/1.1 when communicating over HTTP
...
The "Connection" and "Host" fields were already always provided anyway.
2018-07-09 14:12:23 +02:00
Michael Rash
e6b095a430
Merge pull request #271 from DeforaNetworks/khorben/warnings
...
Addressing most warnings
2018-07-02 23:57:58 -04:00
khorben
5228fe88d0
Avoid compilation warnings from ctype(3) helpers
...
Characters should be casted as unsigned before use in functions from
<ctype.h>. Otherwise the compiler treats 8-bit characters (eg UTF-8) as
negative values (since it expects signed integers) and they no longer
match the comparison tables. Worse, the character 0xff gets interpreted
as -1 (like EOF). In turn, it helps to explicitly cast the result as a
signed integer, since this is what is expected. Characters in the range
0x80-0xff do keep their original values.
See the manual page for ctype(3) for more details (eg from NetBSD)
2018-06-12 14:01:22 -04:00
khorben
42be3dcff5
Avoid a warning about deprecated assertions
2018-06-12 13:48:00 -04:00
Michael Rash
44c3defa4c
Merge pull request #268 from DeforaNetworks/khorben/typo
...
Fix typo in a comment
2018-04-24 21:59:54 -04:00
Michael Rash
92182d34c2
Merge pull request #267 from DeforaNetworks/khorben/netbsd
...
Let fwknop build on NetBSD
2018-04-24 21:59:40 -04:00
khorben
1062021957
Fix typo in a comment
2018-04-25 03:48:24 +02:00
khorben
4d88f08f56
Let fwknop build on NetBSD
2018-04-25 03:47:56 +02:00
Michael Rash
576d09afbf
Merge pull request #260 from mstair/erlang_server
...
Adding Erlang server component
2018-03-16 22:11:15 -04:00
Michael Rash
bd6eb44b8a
Merge pull request #252 from jwilk-forks/httphttp
...
[extras] fix URL in OpenWRT packaging
2018-03-16 22:10:01 -04:00
Michael Stair
6353032ea4
Merge pull request #2 from sparrell/erlang_server
...
Update deprecated crypto:rand_uniform
2018-03-03 15:08:17 -05:00
Duncan Sparrell
3c94f92fb4
Update deprecated crypto:rand_uniform
...
plus fix missing newline
2018-03-03 13:49:40 -05:00
Michael Stair
4486489570
Merge pull request #1 from sparrell/erlang_server
...
server on localhost
2018-03-03 12:38:00 -05:00
Duncan Sparrell
5c5911e96a
server on localhost
2018-03-03 11:09:32 -05:00
Michael Stair
f0f8abd8e8
Adding erlang spa server component
2017-11-27 10:16:14 -05:00
Michael Rash
Michael Rash
khorben
Michael Stair
Duncan Sparrell