Franck Joncourt
17a105fd8a
Added GPG_SIGNER and GPG_RECIPIENT to the list of important variables.
2013-05-05 21:43:31 +02:00
Franck Joncourt
b8145f6d7f
Added --force-stanza command line arg to avoid prompting the user.
2013-05-05 21:13:26 +02:00
Franck Joncourt
9d8d1de60d
Ask the user whether he wants to overwrite a variable in the updated rc file or not.
2013-05-04 17:02:02 +02:00
Franck Joncourt
9f43f7a6ff
Merge remote-tracking branch 'upstream/master'
2013-05-04 15:34:34 +02:00
Franck Joncourt
f217506234
Fixed names of function for better understanding.
2013-05-04 15:33:03 +02:00
Michael Rash
d61d5b964e
[test suite] added Cygwin client compatibility tests
2013-05-03 23:17:24 -04:00
Michael Rash
589a68b97b
[test suite] additional iptables init/exit 'no flush' tests
2013-05-03 20:56:05 -04:00
Michael Rash
df5f2d3ac0
[test suite] minor update to not count HMAC OpenSSL tests against non-ascii HMAC keys when the hexkey option is not supported
2013-05-03 20:55:20 -04:00
Michael Rash
5f06cefb02
[test suite] added check for test script inclusion in Makefile.am
2013-05-03 08:35:24 -04:00
Franck Joncourt
84768dda6f
Continued implementing a way to not overwrite KEY.. variables with --save-rc-stanza
...
mrash/fwknop#67
2013-05-03 13:49:32 +02:00
Michael Rash
c086105eb1
[server] added tests on Linux systems for the iptables FLUSH_IPT_* vars
2013-05-02 22:29:51 -04:00
Michael Rash
2297dfd8c2
[server] minor memory leak bug fix for invalid date processing
...
Bug fix to ensure to release memory when invalid access stanza dates are set
and fwknopd has to exit. This leak was caught with the test suite in
--enable-valgrind mode based on the following output:
==31947== 568 bytes in 1 blocks are still reachable in loss record 1 of 1
==31947== at 0x4C2CD7B: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==31947== by 0x52EE42A: __fopen_internal (iofopen.c:73)
==31947== by 0x1116A2: parse_access_file (access.c:909)
==31947== by 0x10BAD5: main (fwknopd.c:194)
2013-05-02 22:26:21 -04:00
Franck Joncourt
c71ce885be
First attempt to not ovewrite some configuration variables with --save-rc-stanza.
...
At this time it only does not overwrite the KEY and HMAC variable without asking the user
what he wants to do.
2013-05-02 23:58:28 +02:00
Michael Rash
56ef34738e
[test suite] add new test files to Makefile.am
2013-05-02 15:08:04 -04:00
Franck Joncourt
23de2d6b5f
Removed duplicate variable in the test suite (fake_spoof_ip/spoof_ip).
2013-05-01 15:52:01 +02:00
Franck Joncourt
fca497f0d8
New tests for rc file processing (SPA_SOURCE_PORT, FW_TIMEOUT).
...
Added spa source port variable to dump_transmit_options() and renamed port
to destination port.
2013-05-01 15:29:17 +02:00
Franck Joncourt
209c0f16da
Protocol string is set has const char in fko_protocol_t.
2013-05-01 14:33:35 +02:00
Michael Rash
0f24877762
[test suite] minor comment addition so this isn't a zero-byte file
2013-05-01 08:21:11 -04:00
Franck Joncourt
d93648cf99
Moved/Created proto_intostr() and proto_strtoint() to utils.c.
...
This allows to update dump_transmit_options() to use the log module to dump data.
2013-04-30 22:22:03 +02:00
Franck Joncourt
10a4e1f675
Updated the TParam typedef to conform to the fko_cli_options_t typedef.
2013-04-30 15:37:08 +02:00
Franck Joncourt
2110790a30
Added new rc file processing tests for the SPA_SERVER_PORT.
2013-04-30 13:54:58 +02:00
Michael Rash
90175250e5
[client] add USE_HMAC handling to parse_rc_param()
2013-04-29 22:14:39 -04:00
Michael Rash
892ee15ff9
ChangeLog and credits updates for Franck
2013-04-29 21:52:07 -04:00
Michael Rash
df5066447d
Started on --save-rc-stanza tests, client bug fix for HMAC verification in --test mode
2013-04-29 21:43:21 -04:00
Franck Joncourt
b53699ef92
Added tests for the SPA_SERVER_PROTO variable from an rc file.
2013-04-29 22:53:06 +02:00
Franck Joncourt
36202d8c66
Merge remote-tracking branch 'upstream/master'
2013-04-29 22:21:18 +02:00
Franck Joncourt
7a719389ca
Integrated the log module in the whol client source code.
...
perror() is also replaced by log_msg()
2013-04-29 22:18:29 +02:00
Michael Rash
ea5bb6937a
[test suite] add client rc file processing tests (digest only for now, more coming)
2013-04-28 21:52:14 -04:00
Michael Rash
b719c06769
[client] ensure to set HMAC mode by default only when an HMAC key is used
2013-04-28 21:51:16 -04:00
Michael Rash
486f0ea52f
[test suite] restore gpg directories after test suite runs
2013-04-27 22:41:17 -04:00
Michael Rash
dd05975217
Merge remote-tracking branch 'fjoncourt/master'
...
This merges changes from Franck Joncourt for issues #55 (log module for fwknop)
and #64 (hostname resolution not working for -P icmp spoofing).
2013-04-27 22:26:38 -04:00
Michael Rash
12a6e9e93a
Convert most strlcat() calls to use destination bound from sizeof()
...
This commit helps to ensure correctness of strlcat() calls in support of fixing
issue #2 .
2013-04-27 20:41:12 -04:00
Franck Joncourt
b04de687ce
Fixed hostname resolution while spoof ip is used.
...
mrash/fwknop#64
2013-04-27 23:31:40 +02:00
Franck Joncourt
0bf0d8f876
Merge remote-tracking branch 'upstream/master'
2013-04-27 22:38:27 +02:00
Franck Joncourt
6063679c6d
Continue implementing the log_msg module.
2013-04-27 22:19:40 +02:00
Michael Rash
b3f55bf1ab
Convert most strlcpy() calls to use destination bound from sizeof()
...
This commit helps to ensure correctness of strlcpy() calls in support of fixing
issue #2 .
2013-04-27 15:08:11 -04:00
Michael Rash
6b095d948d
[test suite] minor openssl verification update to print base64 decode flag value
2013-04-27 12:56:50 -04:00
Michael Rash
eb727e1271
removed roadmap.org file in favor of using github milestones
2013-04-26 21:56:26 -04:00
Michael Rash
6036619b1c
removed todo.org file in favor of using github issues
2013-04-26 21:47:49 -04:00
Franck Joncourt
2396193e06
Replaced all references to *fprintf(stderr,* by log_msg() in config_init.c
2013-04-26 17:16:05 +02:00
Franck Joncourt
65d0517a9c
Inverted log level enumeration
2013-04-26 16:18:08 +02:00
Franck Joncourt
bb70a9752f
Ajout du module log_msg pour le client
2013-04-26 14:08:25 +02:00
Michael Rash
0ec547e04d
[server] another minor CLANG static analyzer fix
2013-04-25 21:32:02 -04:00
Michael Rash
a6e8919728
[server] fix minor CLANG static analyzer bugs
...
These are simple logic fixes that would not have impacted run time to address
the following warnings generated by the CLANG static analyzer:
incoming_spa.c:433:17: warning: Value stored to 'attempted_decrypt' is never read
attempted_decrypt = 1;
^ ~
incoming_spa.c:647:13: warning: Value stored to 'acc' is never read
acc = acc->next;
^ ~~~~~~~~~
2013-04-25 21:29:37 -04:00
Franck Joncourt
bf889f7b6e
Used args enumeration for both the update_rc() and add_rc_param().
...
Updated fwknop client to refer to the fwknop args enumeration rather
than the config variable names directly. This should make easier to
handle future changes of the variable name.
New function to validate a string matches a YES pattern in the configuration
file : is_yes_str().
The parse_rc_param() only returns at the end of the function, unless a fatal
error has been encountered.
2013-04-25 23:03:02 +02:00
Michael Rash
5e82adbf3f
[test suite] added GPG password required HMAC tests, added --disable-valgrind argument
2013-04-23 21:56:41 -04:00
Michael Rash
4ea683678b
[test suite] added gpg_no_pw_hmac_access.conf file
2013-04-22 20:59:32 -04:00
Michael Rash
f02cc0ddd2
Added HMAC support to GPG encryption modes, closes #58
2013-04-22 20:45:59 -04:00
Michael Rash
2f72960e0f
[test suite] clean command tmp files before and after each test
2013-04-21 21:13:15 -04:00
Michael Rash
08add2fd48
[server] minor function prototype convention update for create_rule()
2013-04-21 20:48:42 -04:00