Commit Graph
2588 Commits
Author SHA1 Message Date
khorben 0b475ec7b3 Use execvp() instead of execvpe()
execvp() is (usually) equivalent to execvpe(), without enforcing any
change to the environment. However, unlike execvp(), execvpe() is not
standardized by POSIX, and may therefore not be available nor detected
when configuring the project (like on NetBSD).

No place could be found in fwknop to be using execvpe() and changing the
environment. Therefore it seems only logical (and safer) to use execvp()
instead.

This also updates the tests to reflect this change.
2018-08-06 12:04:45 +02:00
Michael Rash ae089b1bad Merge pull request #280 from DeforaNetworks/khorben/connect-error-format 2018-07-25 18:42:29 -04:00
khorben 6d6a722128 Fix incomplete format string upon errors 2018-07-25 22:35:03 +02:00
Michael Rash e0c860d2c7 Merge pull request #277 from DeforaNetworks/khorben/usage
More consistent usage screens
2018-07-18 21:28:48 -04:00
khorben 8a1289cdc9 More consistent usage screens 2018-07-17 16:45:46 +02:00
Michael Rash b4c75d195f Merge pull request #274 from DeforaNetworks/khorben/typo 2018-07-11 22:36:40 -04:00
khorben 50f56a581f Fix the configuration variable name for GPG_DECRYPT_PW 2018-07-10 11:31:54 +02:00
Michael Rash e6b095a430 Merge pull request #271 from DeforaNetworks/khorben/warnings
Addressing most warnings
2018-07-02 23:57:58 -04:00
khorben 5228fe88d0 Avoid compilation warnings from ctype(3) helpers
Characters should be casted as unsigned before use in functions from
<ctype.h>. Otherwise the compiler treats 8-bit characters (eg UTF-8) as
negative values (since it expects signed integers) and they no longer
match the comparison tables. Worse, the character 0xff gets interpreted
as -1 (like EOF). In turn, it helps to explicitly cast the result as a
signed integer, since this is what is expected. Characters in the range
0x80-0xff do keep their original values.

See the manual page for ctype(3) for more details (eg from NetBSD)
2018-06-12 14:01:22 -04:00
khorben 42be3dcff5 Avoid a warning about deprecated assertions 2018-06-12 13:48:00 -04:00
Michael Rash 44c3defa4c Merge pull request #268 from DeforaNetworks/khorben/typo
Fix typo in a comment
2018-04-24 21:59:54 -04:00
Michael Rash 92182d34c2 Merge pull request #267 from DeforaNetworks/khorben/netbsd
Let fwknop build on NetBSD
2018-04-24 21:59:40 -04:00
khorben 1062021957 Fix typo in a comment 2018-04-25 03:48:24 +02:00
khorben 4d88f08f56 Let fwknop build on NetBSD 2018-04-25 03:47:56 +02:00
Michael Rash 576d09afbf Merge pull request #260 from mstair/erlang_server
Adding Erlang server component
2018-03-16 22:11:15 -04:00
Michael Rash bd6eb44b8a Merge pull request #252 from jwilk-forks/httphttp
[extras] fix URL in OpenWRT packaging
2018-03-16 22:10:01 -04:00
Michael Stair 6353032ea4 Merge pull request #2 from sparrell/erlang_server
Update deprecated crypto:rand_uniform
2018-03-03 15:08:17 -05:00
Duncan Sparrell 3c94f92fb4 Update deprecated crypto:rand_uniform
plus fix missing newline
2018-03-03 13:49:40 -05:00
Michael Stair 4486489570 Merge pull request #1 from sparrell/erlang_server
server on localhost
2018-03-03 12:38:00 -05:00
Duncan Sparrell 5c5911e96a server on localhost 2018-03-03 11:09:32 -05:00
Michael Stair f0f8abd8e8 Adding erlang spa server component 2017-11-27 10:16:14 -05:00
Michael Rash ecb25a042c regenerate fwknopd man page with Jonathan's pcap loop fix 2017-09-18 22:25:52 -04:00
Michael Rash 3cd88ac62e Merge branch 'master' of ssh://github.com/mrash/fwknop 2017-09-18 22:20:31 -04:00
Michael Rash 8c33a104d6 a further byte-order refinement 2017-09-18 22:20:02 -04:00
Jonathan Bennett e89d2c38e0 Correct default value of PCAP_LOOP_SLEEP in man page
The default value of PCAP_LOOP_SLEEP was misstated, a 0 was missed.
2017-09-11 23:27:26 -05:00
Michael Rash a617502b25 update ChangeLog with OpenBSD endian fix 2017-09-09 09:22:02 -04:00
Michael Rash 10d31064c3 Endian fix for OpenBSD systems
Per github issue #257, Jérémie Courrèges-Anglas and Ingo Feinerer
contributed a patch to fix endian detection on OpenBSD systems. This is
based on information contained at:

https://www.opengroup.org/austin/docs/austin_514.txt
2017-09-09 09:06:07 -04:00
Jakub Wilk ca320c1c73 [extras] fix URL in OpenWRT packaging 2017-04-25 21:12:24 +02:00
Michael Rash 78b3a215cb fix gnupg.org link in the ChangeLog 2017-04-15 08:56:13 -04:00
Michael Rash d5c841140f image markdown fix for the README 2017-03-28 23:03:16 -04:00
Michael Rash 013509832e Merge branch 'master' of ssh://moria/home/mbr/git/fwknop 2017-03-28 22:57:12 -04:00
Michael Rash 456b51693f minor README images path update 2017-03-28 22:56:08 -04:00
Michael Rash bc1505934e Merge branch 'master' of ssh://github.com/mrash/fwknop 2017-02-20 22:09:56 -05:00
Michael Rash ac9ccb9ab0 [libfko] check NULL ptr before utilizing - discovered by the PVS-Studio static analyzer 2017-02-20 21:54:22 -05:00
Michael Rash 9f963df723 minor comment addition 2017-02-20 21:51:35 -05:00
Michael Rash 5dffde18fd Merge pull request #250 from jwilk/python-errstr 2017-02-12 16:46:50 -05:00
Jakub Wilk 42ebb04605 [python] fix name error in Fko.errstr() 2017-02-09 12:16:29 +01:00
Michael Rash d579c6cd0f Merge pull request #249 from jwilk/python-cfb 2017-01-26 21:04:34 -05:00
Jakub Wilk 8f5d9c0e82 [python] Fix typo in CFB mode 2017-01-26 19:29:30 +01:00
Michael Rash d7412af09e [test suite] don't use shell redirection char in bogus IP string 2016-12-09 19:23:11 -05:00
Michael Rash 8b734049a7 [test suite] only run user/group parity tests for non-root owner user 2016-12-09 19:17:24 -05:00
Michael Rash 643805967e remove ChangeLog.git file since people should just get this information from git 2016-12-04 16:32:50 -05:00
Michael Rash f05b1a7a0d Merge pull request #245 from mstair/erlang_client
[erlang] updating Erlang .gitignore and build dependencies
2016-11-19 14:49:22 -05:00
Michael Stair b25f8ed970 [erlang] explicit pull of pkcs7 from master branch 2016-11-19 13:21:40 -05:00
Michael Stair d2810c6ce1 [erlang] removing rebar.lock 2016-11-19 13:16:00 -05:00
Michael Stair 5545b1c4f2 [erlang] remove rebar.lock and update .gitignore 2016-11-19 13:13:42 -05:00
Michael Rash 0e1634a8b1 Merge pull request #244 from mstair/erlang_client
[erlang] initial checkin of Erlang client
2016-11-19 09:24:53 -05:00
Michael Stair 88cff80690 [erlang] initial checkin of Erlang client 2016-11-18 13:29:23 -05:00
Michael Rash 00669b2be0 Merge pull request #241 from fjoncourt/apparmor
Fix apparmor profil for Ubuntu
2016-11-11 19:46:57 -05:00
Franck Joncourt 861111bd1e Fix apparmor profil for Ubuntu
Refer to https://bugs.launchpad.net/ubuntu/+source/fwknop/+bug/1598506
2016-11-11 22:19:02 +01:00