DeforaNetworks/fwknop
3
0
Fork 0
Code Releases Activity

[client] bug fix to ensure -a overrides IP resolution

Browse Source
This commit is contained in:
Michael Rash
2014-11-18 23:10:19 -05:00
parent 22289a3f58
commit ece855b66a
1 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/config_init.c
+13 -13
View File
@@ -1791,7 +1791,7 @@ validate_options(fko_cli_options_t *options)
strlcpy(options->use_rc_stanza, options->spa_server_str, sizeof(options->use_rc_stanza));
}
/* Gotta have a Destination unless we are just testing or getting the
/* Must have a destination unless we are just testing or getting the
* the version, and must use one of [-s|-R|-a].
*/
if(!options->test
@@ -1825,20 +1825,20 @@ validate_options(fko_cli_options_t *options)
"[-] WARNING: Should use -a or -R to harden SPA against potential MITM attacks");
}
}
}
/* Make sure -a overrides IP resolution
*/
if(options->allow_ip_str[0] != 0x0
&& strncasecmp(options->allow_ip_str, "resolve", strlen("resolve")) != 0)
/* Make sure -a overrides IP resolution
*/
if(options->allow_ip_str[0] != 0x0
&& strncasecmp(options->allow_ip_str, "resolve", strlen("resolve")) != 0)
{
options->resolve_ip_http_https = 0;
if(! is_valid_ipv4_addr(options->allow_ip_str))
{
options->resolve_ip_http_https = 1;
if(! is_valid_ipv4_addr(options->allow_ip_str))
{
log_msg(LOG_VERBOSITY_ERROR,
"Invalid allow IP specified for SPA access");
exit(EXIT_FAILURE);
}
log_msg(LOG_VERBOSITY_ERROR,
"Invalid allow IP specified for SPA access");
exit(EXIT_FAILURE);
}
}