Check for non-null pointer value

If a base64 encoded key is provided twice, add_acc_b64_string() was using malloc to allocate a second key value without first freeing the previous value. This patch adds null checks, and frees the previous memory usage if needed.
2016-02-22 21:26:23 -06:00
parent deed691c4e
commit 8542655fd7
1 changed files with 11 additions and 0 deletions
@@ -153,6 +153,17 @@ static void
 add_acc_b64_string(char **var, int *len, const char *val, FILE *file_ptr,
        fko_srv_options_t *opts)
 {
+    if(var == NULL)
+    {
+        log_msg(LOG_ERR, "[*] add_acc_b64_string() called with NULL variable");
+        if(file_ptr != NULL)
+            fclose(file_ptr);
+        clean_exit(opts, NO_FW_CLEANUP, EXIT_FAILURE);
+    }
+
+    if(*var != NULL)
+        free(*var);
+
    if((*var = strdup(val)) == NULL)
    {
        log_msg(LOG_ERR,