DeforaNetworks/corteza
3
0
Fork 0
Code Activity

Do not parse filters on empty string (avoid "empty node set" error)

Browse Source
This commit is contained in:
Denis Arh
2019-07-02 06:27:25 +02:00
parent 8f3c9d72eb
commit c1de0a5adf
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compose/internal/repository/record_report_builder.go
+8 -6
View File
@@ -141,13 +141,15 @@ func (b *recordReportBuilder) Build(metrics, dimensions, filters string) (sql st
// Use a different handler for filter functions for this
b.parser.OnFunction = stdFilterFuncHandler
var filter ql.ASTNode
if filter, err = b.parser.ParseExpression(filters); err != nil {
err = errors.Wrapf(err, "could not parse filters %q", filters)
return
}
if len(filters) > 0 {
var filter ql.ASTNode
if filter, err = b.parser.ParseExpression(filters); err != nil {
err = errors.Wrapf(err, "could not parse filters %q", filters)
return
}
b.report = b.report.Where(filter)
b.report = b.report.Where(filter)
}
return b.report.ToSql()
}