Add some temporary restrictions for dev release

This commit is contained in:
Tomaž Jerman
2021-09-02 10:43:58 +02:00
parent 933dc744e1
commit 6f5489a71b
4 changed files with 19 additions and 1 deletions
+12
View File
@@ -50,6 +50,13 @@ func (j *stepJoin) Run(ctx context.Context, dd ...Datasource) (Datasource, error
return nil, fmt.Errorf("foreign join datasources not defined: %s", j.def.LocalSource)
}
// @todo temporarily disabled
for _, d := range dd {
if _, ok := d.(*joinedDataset); ok {
return nil, fmt.Errorf("unable to join a joined source: %s", d.Name())
}
}
// @todo multiple joins
return &joinedDataset{
def: j.def,
@@ -399,6 +406,11 @@ func (d *joinedDataset) validateSort(def *FrameDefinition, dd FrameDescriptionSe
}
}
// @todo temporarily disabled
if sortDS != "" {
return fmt.Errorf("[temporary] initial sort can not by by a foreign column: %s", sortDS)
}
// The first one is always local so this is ok
localDscr := dd[0]
var dscr *FrameDescription
@@ -7,6 +7,9 @@ import (
)
func Test3002_joining_base_nested(t *testing.T) {
t.Skip("@todo temporarily disabled")
var (
ctx, h, s = setup(t)
m, _, dd = loadScenario(ctx, s, t, h)
@@ -8,7 +8,7 @@ import (
func Test3003_joining_base_nested_complex(t *testing.T) {
t.Skip("@todo")
t.Skip("@todo temporarily disabled")
var (
ctx, h, s = setup(t)
@@ -7,6 +7,9 @@ import (
)
func Test3006_joining_paging_nested(t *testing.T) {
t.Skip("@todo temporarily disabled")
var (
ctx, h, s = setup(t)
m, _, dd = loadScenario(ctx, s, t, h)