DeforaNetworks/corteza
3
0
Fork 0
Code Activity

Skips removal of accessTokens when we update roleMembers

Browse Source
This commit is contained in:
Vivek Patel
2021-09-24 23:54:37 +05:30
parent 50e5d1a9f8
commit 68af7a4fb0
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
system/service/role.go
+9 -3
View File
@@ -722,9 +722,15 @@ func (svc role) MemberRemove(ctx context.Context, roleID, memberID uint64) (err
return
}
if err = svc.auth.RemoveAccessTokens(ctx, m); err != nil {
return
}
// @todo skipping this for now,
// AS per now PUT `/role/{roleID}` endpoint updates role and it's member with it but
// only if one or more members are included in request otherwise we ignore it,
// which causes issue in admin when we remove all the members from role.
// we have to rework the role membership management logic in admin,
// and use the dedicated endpoints for POST, DELETE role member.
// if err = svc.auth.RemoveAccessTokens(ctx, m); err != nil {
// return
// }
_ = svc.eventbus.WaitFor(ctx, event.RoleMemberAfterRemove(m, r))
return nil