3
0

Use truncAndCreate when available in store tests

This commit is contained in:
Jože Fortun
2020-09-24 11:14:03 +02:00
parent fa3220388a
commit 3cea815fe1
8 changed files with 4 additions and 19 deletions
+1 -2
View File
@@ -44,8 +44,7 @@ func testMessagingChannels(t *testing.T, s store.MessagingChannels) {
})
t.Run("lookup by ID", func(t *testing.T) {
messagingChannel := makeNew("look up by id")
req.NoError(s.CreateMessagingChannel(ctx, messagingChannel))
req, messagingChannel := truncAndCreate(t)
fetched, err := s.LookupMessagingChannelByID(ctx, messagingChannel.ID)
req.NoError(err)
req.Equal(messagingChannel.Name, fetched.Name)
+1 -2
View File
@@ -50,8 +50,7 @@ func testMessagingFlags(t *testing.T, s store.MessagingFlags) {
})
t.Run("lookup by ID", func(t *testing.T) {
messagingFlag := makeNew("look-up-by-id")
req.NoError(s.CreateMessagingFlag(ctx, messagingFlag))
req, messagingFlag := truncAndCreate(t)
fetched, err := s.LookupMessagingFlagByID(ctx, messagingFlag.ID)
req.NoError(err)
req.Equal(messagingFlag.Flag, fetched.Flag)
+1 -2
View File
@@ -49,8 +49,7 @@ func testMessagingMentions(t *testing.T, s store.MessagingMentions) {
})
t.Run("lookup by ID", func(t *testing.T) {
messagingMention := makeNew("look-up-by-id")
req.NoError(s.CreateMessagingMention(ctx, messagingMention))
req, messagingMention := truncAndCreate(t)
fetched, err := s.LookupMessagingMentionByID(ctx, messagingMention.ID)
req.NoError(err)
req.Equal(messagingMention.ID, fetched.ID)
+1 -2
View File
@@ -47,8 +47,7 @@ func testMessagingMessages(t *testing.T, s store.MessagingMessages) {
})
t.Run("lookup by ID", func(t *testing.T) {
messagingMessage := makeNew("look up by id")
req.NoError(s.CreateMessagingMessage(ctx, messagingMessage))
req, messagingMessage := truncAndCreate(t)
fetched, err := s.LookupMessagingMessageByID(ctx, messagingMessage.ID)
req.NoError(err)
req.Equal(messagingMessage.Message, fetched.Message)
-1
View File
@@ -60,7 +60,6 @@ func testReminders(t *testing.T, s store.Reminders) {
t.Run("lookup by ID", func(t *testing.T) {
req, reminder := truncAndCreate(t)
fetched, err := s.LookupReminderByID(ctx, reminder.ID)
req.NoError(err)
req.Equal(reminder.ID, fetched.ID)
-2
View File
@@ -58,7 +58,6 @@ func testRoles(t *testing.T, s store.Roles) {
t.Run("lookup by ID", func(t *testing.T) {
req, role := truncAndCreate(t)
fetched, err := s.LookupRoleByID(ctx, role.ID)
req.NoError(err)
req.Equal(role.Name, fetched.Name)
@@ -76,7 +75,6 @@ func testRoles(t *testing.T, s store.Roles) {
t.Run("lookup by handle", func(t *testing.T) {
req, role := truncAndCreate(t)
fetched, err := s.LookupRoleByHandle(ctx, role.Handle)
req.NoError(err)
req.Equal(role.ID, fetched.ID)
-1
View File
@@ -54,7 +54,6 @@ func testSettings(t *testing.T, s store.Settings) {
t.Run("lookup by name and ownedBy", func(t *testing.T) {
req, setting := truncAndCreate(t)
fetched, err := s.LookupSettingByNameOwnedBy(ctx, setting.Name, setting.OwnedBy)
req.NoError(err)
req.Equal(setting.Name, fetched.Name)
-7
View File
@@ -99,7 +99,6 @@ func testUsers(t *testing.T, s store.Users) {
t.Run("lookup by ID", func(t *testing.T) {
req, user := truncAndCreate(t)
fetched, err := store.LookupUserByID(ctx, s, user.ID)
req.NoError(err)
req.Equal(user.Email, fetched.Email)
@@ -119,7 +118,6 @@ func testUsers(t *testing.T, s store.Users) {
t.Run("lookup by email", func(t *testing.T) {
req, user := truncAndCreate(t)
fetched, err := store.LookupUserByEmail(ctx, s, user.Email)
req.NoError(err)
req.Equal(user.Email, fetched.Email)
@@ -127,7 +125,6 @@ func testUsers(t *testing.T, s store.Users) {
t.Run("lookup by handle", func(t *testing.T) {
req, user := truncAndCreate(t)
fetched, err := store.LookupUserByHandle(ctx, s, user.Handle)
req.NoError(err)
req.Equal(user.ID, fetched.ID)
@@ -135,7 +132,6 @@ func testUsers(t *testing.T, s store.Users) {
t.Run("lookup by nonexisting handle", func(t *testing.T) {
req, _ := truncAndCreate(t)
fetched, err := store.LookupUserByHandle(ctx, s, "no such handle")
req.EqualError(err, "not found")
req.Nil(fetched)
@@ -143,7 +139,6 @@ func testUsers(t *testing.T, s store.Users) {
t.Run("lookup by username", func(t *testing.T) {
req, user := truncAndCreate(t)
fetched, err := store.LookupUserByUsername(ctx, s, user.Username)
req.NoError(err)
req.Equal(user.ID, fetched.ID)
@@ -152,7 +147,6 @@ func testUsers(t *testing.T, s store.Users) {
t.Run("search", func(t *testing.T) {
t.Run("by ID", func(t *testing.T) {
req, prefill := truncAndFill(t, 5)
set, f, err := store.SearchUsers(ctx, s, types.UserFilter{UserID: []uint64{prefill[0].ID}})
req.NoError(err)
req.Equal([]uint64{prefill[0].ID}, f.UserID)
@@ -162,7 +156,6 @@ func testUsers(t *testing.T, s store.Users) {
t.Run("by email", func(t *testing.T) {
req, prefill := truncAndFill(t, 5)
set, _, err := store.SearchUsers(ctx, s, types.UserFilter{Email: prefill[0].Email})
req.NoError(err)
req.Len(set, 1)