DeforaNetworks/corteza
3
0
Fork 0
Code Activity

Simplify message delete permission check

Browse Source
This commit is contained in:
Tomaž Jerman
2019-11-19 17:53:28 +01:00
committed by Denis Arh
parent ea7470acc4
commit 3c68b3b770
1 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
messaging/service/message.go
+6 -10
View File
@@ -364,22 +364,18 @@ func (svc message) Delete(messageID uint64) error {
return ErrNoPermissions.withStack()
}
if deletedMsg.UserID == currentUserID && !svc.ac.CanUpdateOwnMessages(svc.ctx, ch) {
return ErrNoPermissions.withStack()
} else if deletedMsg.UserID != currentUserID && !svc.ac.CanUpdateMessages(svc.ctx, ch) {
return ErrNoPermissions.withStack()
}
if deletedMsg.ReplyTo > 0 {
original, err = svc.message.FindByID(deletedMsg.ReplyTo)
if err != nil {
return err
}
if ch, err = svc.channel.FindByID(original.ChannelID); err != nil {
return
}
if original.UserID == currentUserID && !svc.ac.CanUpdateOwnMessages(svc.ctx, ch) {
return ErrNoPermissions.withStack()
} else if original.UserID != currentUserID && !svc.ac.CanUpdateMessages(svc.ctx, ch) {
return ErrNoPermissions.withStack()
}
// This is a reply to another message, decrease reply counter on the original, on struct and in the
// repository
if original.Replies > 0 {