3
0

Deprecate ACTIONLOG_COMPOSE_RECORD_ENABLED

This commit is contained in:
Denis Arh
2022-07-28 20:03:24 +02:00
parent 508dddd304
commit 39bf9b75ea
4 changed files with 1 additions and 43 deletions

View File

@@ -346,19 +346,6 @@
# Default: <no value>
# ACTIONLOG_WORKFLOW_FUNCTIONS_ENABLED=<no value>
###############################################################################
# Enables actionlog for compose record create, update, and delete. which is disabled by default.
#
# [IMPORTANT]
# ====
# This is temp fix for now, it will be removed completely in future release.
# Once new env var will be introduced for actionlog policy, which will enable more control over action log policies.
# ====
#
# Type: bool
# Default: <no value>
# ACTIONLOG_COMPOSE_RECORD_ENABLED=<no value>
###############################################################################
###############################################################################
# API Gateway

View File

@@ -18,20 +18,6 @@ actionLog: schema.#optionsGroup & {
workflow_functions_enabled: {
type: "bool"
}
compose_record_enabled: {
type: "bool"
defaultGoExpr: "false"
description: """
Enables actionlog for compose record create, update, and delete. which is disabled by default.
[IMPORTANT]
====
This is temp fix for now, it will be removed completely in future release.
Once new env var will be introduced for actionlog policy, which will enable more control over action log policies.
====
"""
}
}
title: "Actionlog"
}

View File

@@ -112,19 +112,6 @@ func Initialize(ctx context.Context, log *zap.Logger, s store.Storer, c Config)
tee = logger.MakeDebugLogger()
}
// Record log policy update
if !c.ActionLog.ComposeRecordEnabled {
policy = actionlog.NewPolicyAll(
policy,
actionlog.NewPolicyAll(
actionlog.NewPolicyMatchResource("compose:record"),
actionlog.NewPolicyMatchAction("create", "update", "delete"),
actionlog.NewPolicyMatchSeverity(actionlog.Emergency),
),
)
}
DefaultActionlog = actionlog.NewService(DefaultStore, log, tee, policy)
}

View File

@@ -79,7 +79,6 @@ type (
Enabled bool `env:"ACTIONLOG_ENABLED"`
Debug bool `env:"ACTIONLOG_DEBUG"`
WorkflowFunctionsEnabled bool `env:"ACTIONLOG_WORKFLOW_FUNCTIONS_ENABLED"`
ComposeRecordEnabled bool `env:"ACTIONLOG_COMPOSE_RECORD_ENABLED"`
}
ApigwOpt struct {
@@ -456,8 +455,7 @@ func SMTP() (o *SMTPOpt) {
// This function is auto-generated
func ActionLog() (o *ActionLogOpt) {
o = &ActionLogOpt{
Enabled: true,
ComposeRecordEnabled: false,
Enabled: true,
}
// Custom defaults