From ab36dbb61a5e3c4d8eb33e3494c5d42fd5405d61 Mon Sep 17 00:00:00 2001
From: skyanth <skyanth@gmail.com>
Date: Tue, 14 May 2019 14:35:53 +0200
Subject: [PATCH] Better linking to non-existent targets in execsummary

---
 xml/xslt/inline.xslt | 75 +++++++++++++++++++++++++++++++-------------
 1 file changed, 53 insertions(+), 22 deletions(-)

diff --git a/xml/xslt/inline.xslt b/xml/xslt/inline.xslt
index 6125497..b2365c9 100644
--- a/xml/xslt/inline.xslt
+++ b/xml/xslt/inline.xslt
@@ -21,10 +21,20 @@
                     DOCUMENT</fo:inline>
             </xsl:when>
             <xsl:when
-                test="(starts-with(@href, '#') and //*[@id = $destination][ancestor-or-self::*[@visibility = 'hidden']]) or (starts-with(@href, '#') and $execsummary=true() and //*[@id = $destination][ancestor-or-self::*[not(@inexecsummary='yes')]])">
+                test="(starts-with(@href, '#') and //*[@id = $destination][ancestor-or-self::*[@visibility = 'hidden']])">
                 <fo:inline xsl:use-attribute-sets="errortext">WARNING: LINK TARGET IS
                     HIDDEN</fo:inline>
             </xsl:when>
+            <xsl:when
+                test="starts-with(@href, '#') and $execsummary = true() and //*[@id = $destination][ancestor-or-self::*[not(@inexecsummary = 'yes')]]">
+                <!-- linking to something that is not in the exec summary -->
+                <xsl:value-of select="local-name(*[@id = $destination])"/>
+                <xsl:text> </xsl:text>
+                <xsl:call-template name="linkText">
+                    <xsl:with-param name="destination" select="$destination"/>
+                    <xsl:with-param name="execsummary_linking_to_content_not_in_report" select="true()"></xsl:with-param>
+                </xsl:call-template>
+            </xsl:when>
             <xsl:otherwise>
                 <fo:basic-link xsl:use-attribute-sets="link">
                     <xsl:choose>
@@ -39,34 +49,53 @@
                             </xsl:attribute>
                         </xsl:otherwise>
                     </xsl:choose>
-                    <xsl:choose>
-                        <xsl:when test="starts-with(@href, '#') and not(text())">
-                            <xsl:for-each select="key('rosid', $destination)">
-                                <xsl:if
-                                    test="not(local-name() = 'appendix' or local-name() = 'finding')">
-                                    <!-- appendix already has 'appendix' as part of its numbering, findings should not be prefixed with the word 'finding' -->
-                                    <xsl:value-of select="local-name()"/>
-                                    <xsl:text> </xsl:text>
-                                </xsl:if>
-                                <xsl:apply-templates select="." mode="number"/>
-                            </xsl:for-each>
-                        </xsl:when>
-                        <xsl:otherwise>
-                            <xsl:apply-templates select="* | text()"/>
-                        </xsl:otherwise>
-                    </xsl:choose>
+                    <xsl:call-template name="linkText">
+                        <xsl:with-param name="destination" select="$destination"/>
+                    </xsl:call-template>
                 </fo:basic-link>
                 <xsl:if test="starts-with(@href, '#')">
                     <xsl:if test="not(@includepage = 'no')">
                         <xsl:text> (page </xsl:text>
-                    <fo:page-number-citation ref-id="{substring(@href, 2)}"/>
-                    <xsl:text>)</xsl:text>
+                        <fo:page-number-citation ref-id="{substring(@href, 2)}"/>
+                        <xsl:text>)</xsl:text>
                     </xsl:if>
                 </xsl:if>
             </xsl:otherwise>
         </xsl:choose>
     </xsl:template>
 
+    <xsl:template name="linkText">
+        <xsl:param name="execsummary_linking_to_content_not_in_report" select="false()"/>
+        <xsl:param name="destination"/>
+        <xsl:choose>
+            <xsl:when test="starts-with(@href, '#') and not(text())">
+                <xsl:for-each select="key('rosid', $destination)">
+                    <xsl:choose>
+                    <xsl:when test="$execsummary_linking_to_content_not_in_report = false()">
+                    <xsl:if test="not(local-name() = 'appendix' or local-name() = 'finding')">
+                        <!-- appendix already has 'appendix' as part of its numbering, findings should not be prefixed with the word 'finding' -->
+                        <xsl:value-of select="local-name()"/>
+                        <xsl:text> </xsl:text>
+                    </xsl:if>
+                    <xsl:apply-templates select="." mode="number"/>
+                        </xsl:when>
+                    <xsl:otherwise>
+                        <xsl:if test="not(local-name() = 'appendix')">
+                        <!-- appendix already has 'appendix' as part of its numbering, findings should not be prefixed with the word 'finding' -->
+                        <xsl:value-of select="local-name()"/>
+                        <xsl:text> </xsl:text>
+                    </xsl:if>
+                    <xsl:apply-templates select="." mode="number"/>
+                    </xsl:otherwise>
+                </xsl:choose>
+                </xsl:for-each>
+            </xsl:when>
+            <xsl:otherwise>
+                <xsl:apply-templates select="* | text()"/>
+            </xsl:otherwise>
+        </xsl:choose>
+    </xsl:template>
+
     <xsl:template match="a" mode="summarytable">
         <xsl:variable name="destination">
             <xsl:choose>
@@ -196,8 +225,8 @@
                     </xsl:attribute>
                     <xsl:text>[</xsl:text>
                     <xsl:for-each select="key('biblioid', $bibid)">
-                                <xsl:apply-templates select="." mode="number"/>
-                            </xsl:for-each>
+                        <xsl:apply-templates select="." mode="number"/>
+                    </xsl:for-each>
                     <xsl:text>]</xsl:text>
                 </fo:basic-link>
             </xsl:otherwise>
@@ -330,7 +359,9 @@
     <xsl:template match="link">
         <xsl:apply-templates select="a"/>
         <xsl:text>. </xsl:text>
-        <xsl:if test="accessed"><xsl:apply-templates select="accessed"/></xsl:if>
+        <xsl:if test="accessed">
+            <xsl:apply-templates select="accessed"/>
+        </xsl:if>
     </xsl:template>
 
     <xsl:template match="accessed">