Up until now we relied on implicit loading of middlewares and reducers, through having imports in each feature's index.js. This leads to many complex import cycles which result in (sometimes) hard to fix bugs in addition to (often) breaking mobile because a web-only feature gets imported on mobile too, thanks to the implicit loading. This PR changes that to make the process explicit. Both middlewares and reducers are imported in a single place, the app entrypoint. They have been divided into 3 categories: any, web and native, which represent each of the platforms respectively. Ideally no feature should have an index.js exporting actions, action types and components, but that's a larger ordeal, so this is just the first step in getting there. In order to both set example and avoid large cycles the app feature has been refactored to not have an idex.js itself.
70 lines
1.8 KiB
JavaScript
70 lines
1.8 KiB
JavaScript
// @flow
|
|
|
|
import _ from 'lodash';
|
|
|
|
import { createToolbarEvent, sendAnalytics } from '../../analytics';
|
|
import { appNavigate } from '../../app/actions';
|
|
import { disconnect } from '../../base/connection';
|
|
import { translate } from '../../base/i18n';
|
|
import { connect } from '../../base/redux';
|
|
import { AbstractHangupButton } from '../../base/toolbox';
|
|
import type { AbstractButtonProps } from '../../base/toolbox';
|
|
|
|
/**
|
|
* The type of the React {@code Component} props of {@link HangupButton}.
|
|
*/
|
|
type Props = AbstractButtonProps & {
|
|
|
|
/**
|
|
* The redux {@code dispatch} function.
|
|
*/
|
|
dispatch: Function
|
|
};
|
|
|
|
/**
|
|
* Component that renders a toolbar button for leaving the current conference.
|
|
*
|
|
* @extends AbstractHangupButton
|
|
*/
|
|
class HangupButton extends AbstractHangupButton<Props, *> {
|
|
_hangup: Function;
|
|
|
|
accessibilityLabel = 'toolbar.accessibilityLabel.hangup';
|
|
label = 'toolbar.hangup';
|
|
tooltip = 'toolbar.hangup';
|
|
|
|
/**
|
|
* Initializes a new HangupButton instance.
|
|
*
|
|
* @param {Props} props - The read-only properties with which the new
|
|
* instance is to be initialized.
|
|
*/
|
|
constructor(props: Props) {
|
|
super(props);
|
|
|
|
this._hangup = _.once(() => {
|
|
sendAnalytics(createToolbarEvent('hangup'));
|
|
|
|
// FIXME: these should be unified.
|
|
if (navigator.product === 'ReactNative') {
|
|
this.props.dispatch(appNavigate(undefined));
|
|
} else {
|
|
this.props.dispatch(disconnect(true));
|
|
}
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Helper function to perform the actual hangup action.
|
|
*
|
|
* @override
|
|
* @protected
|
|
* @returns {void}
|
|
*/
|
|
_doHangup() {
|
|
this._hangup();
|
|
}
|
|
}
|
|
|
|
export default translate(connect()(HangupButton));
|