From d7c9a97e8d8199ea0c0d23d48fb18a8ee17d2a6f Mon Sep 17 00:00:00 2001 From: Lyubomir Marinov Date: Wed, 13 Jan 2016 19:05:44 +0200 Subject: [PATCH] Adds a FIXME (comment) to make a note of the fact that loading analytics.js after modules/statistics/AnalyticsAdapter.js forces the method AnalyticsAdapter.sendEvent to a no-op. --- index.html | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/index.html b/index.html index d66835e1d..112eea348 100644 --- a/index.html +++ b/index.html @@ -226,6 +226,13 @@ if (!config.disableThirdPartyRequests) { [ 'https://api.callstats.io/static/callstats.min.js', + // FIXME The implementation provided by analytics.js starts an + // asynchronous download of the Google Analytics integration. + // Unfortunately, modules/statistics/AnalyticsAdapter.js has already + // made the decision to not use it at the current point of the + // execution and has initialized itself with the NoopAnalytics + // implementation i.e. the implementation of the method + // AnalyticsAdapter.sendEvent will amount to nothing. 'analytics.js?v=1' ].forEach(function(extSrc) { var extScript = document.createElement('script');