From bfb45ed0e819ffde69d6248235433df200d3efd6 Mon Sep 17 00:00:00 2001 From: virtuacoplenny Date: Tue, 13 Mar 2018 14:37:35 -0700 Subject: [PATCH] fix(large-video): do not try to show background on safari with webrtc (#2606) The animation for toggling filmstrip visibility was lagging on Safari. Even though the background video is set to hidden, it is still causing issues. Setting the background to display none instead does help but might interfere with animations. So instead do the easy thing and re-use logic used for Firefox to not show the background video. --- modules/UI/videolayout/VideoContainer.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/modules/UI/videolayout/VideoContainer.js b/modules/UI/videolayout/VideoContainer.js index 1ec9578f1..0a3317862 100644 --- a/modules/UI/videolayout/VideoContainer.js +++ b/modules/UI/videolayout/VideoContainer.js @@ -687,7 +687,11 @@ export class VideoContainer extends LargeContainer { * @returns {void} */ _updateBackground() { - if (browser.isFirefox() || browser.isTemasysPluginUsed()) { + // Do not the background display on browsers that might experience + // performance issues from the presence of the background. + if (browser.isFirefox() + || browser.isSafariWithWebrtc() + || browser.isTemasysPluginUsed()) { return; }