From 6bbc2927ab56e6924ca58db84235e173652cb130 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sa=C3=BAl=20Ibarra=20Corretg=C3=A9?= Date: Tue, 30 Apr 2019 21:10:18 +0200 Subject: [PATCH] analytics: don't initialize handlers if they are not properly configured --- react/features/analytics/handlers/AmplitudeHandler.js | 7 +------ .../features/analytics/handlers/GoogleAnalyticsHandler.js | 8 +------- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/react/features/analytics/handlers/AmplitudeHandler.js b/react/features/analytics/handlers/AmplitudeHandler.js index d63111bf8..08d68b5b4 100644 --- a/react/features/analytics/handlers/AmplitudeHandler.js +++ b/react/features/analytics/handlers/AmplitudeHandler.js @@ -1,8 +1,6 @@ import AbstractHandler from './AbstractHandler'; import { amplitude } from './amplitude'; -const logger = require('jitsi-meet-logger').getLogger(__filename); - /** * Analytics handler for Amplitude. */ @@ -20,10 +18,7 @@ export default class AmplitudeHandler extends AbstractHandler { const { amplitudeAPPKey, host } = options; if (!amplitudeAPPKey) { - logger.warn( - 'Failed to initialize Amplitude handler, no APP key'); - - return; + throw new Error('Failed to initialize Amplitude handler, no APP key'); } this._enabled = true; diff --git a/react/features/analytics/handlers/GoogleAnalyticsHandler.js b/react/features/analytics/handlers/GoogleAnalyticsHandler.js index 37e86ffe2..50db3a286 100644 --- a/react/features/analytics/handlers/GoogleAnalyticsHandler.js +++ b/react/features/analytics/handlers/GoogleAnalyticsHandler.js @@ -4,8 +4,6 @@ import { getJitsiMeetGlobalNS } from '../../base/util'; import AbstractHandler from './AbstractHandler'; -const logger = require('jitsi-meet-logger').getLogger(__filename); - /** * Analytics handler for Google Analytics. */ @@ -24,11 +22,7 @@ class GoogleAnalyticsHandler extends AbstractHandler { this._userProperties = {}; if (!options.googleAnalyticsTrackingId) { - logger.warn( - 'Failed to initialize Google Analytics handler, no tracking ID' - ); - - return; + throw new Error('Failed to initialize Google Analytics handler, no tracking ID'); } this._enabled = true;