From 53c232fd76255535dd3350e4dbfb9500da43dd6a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sa=C3=BAl=20Ibarra=20Corretg=C3=A9?= Date: Fri, 1 Feb 2019 14:55:43 +0100 Subject: [PATCH] misc: fix off-by-one error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit e729f0948cc57102bd8406b40cc1f92125c1603f contained an off-by-one error: URI_PROTOCOL_PATTERN includes the colon, so after applyting the regex we are left with something like '//example.com/room' thus we only need to strip the first 2 characters. 🤦 --- react/features/deep-linking/functions.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/react/features/deep-linking/functions.js b/react/features/deep-linking/functions.js index fc17ea12b..717e3306e 100644 --- a/react/features/deep-linking/functions.js +++ b/react/features/deep-linking/functions.js @@ -51,7 +51,7 @@ export function generateDeepLinkingURL() { // https://developer.chrome.com/multidevice/android/intents if (Platform.OS === 'android') { // https://meet.jit.si/foo -> meet.jit.si/foo - const url = href.replace(regex, '').substr(3); + const url = href.replace(regex, '').substr(2); const pkg = interfaceConfig.ANDROID_APP_PACKAGE || 'org.jitsi.meet'; return `intent://${url}/#Intent;scheme=${appScheme};package=${pkg};end`;