DeforaNetworks/jitsi-meet
3
0
Fork 0
Code Releases Activity

ref: move all prop type declaration to flow

Browse Source 
For the most part the changes are taking the "static propTypes" declaration off
of components and declaring them as Flow types. Sometimes to support flow some
method signatures had to be added. There are some exceptions in which more had
to be done to tame the beast:
- AbstractVideoTrack: put in additional truthy checks for videoTrack.
- Video: add truthy checks for the _videoElement ref.
- shouldRenderVideoTrack function: Some component could pass null for the
  videoTrack argument and Flow wanted that called out explicitly.
- DisplayName: Add a truthy check for the input ref before acting on it.
- NumbersList: Move array checks inline for Flow to comprehend array methods
  could be called. Add type checks in the Object.entries loop as the value is
  assumed to be a mixed type by Flow.
- AbstractToolbarButton: add additional truthy check for passed in type.
This commit is contained in:
Leonard Kim
2018-10-29 22:02:23 -07:00
committed by Zoltan Bettenbuk
parent 554974a36d
commit 486e8e35d9
77 changed files with 2815 additions and 2456 deletions
Download Patch File Download Diff File Expand all files Collapse all files

123
react/features/authentication/components/LoginDialog.native.js
View File

@@ -1,4 +1,5 @@
import PropTypes from 'prop-types';
/* @flow */
import React, { Component } from 'react';
import { Text, TextInput, View } from 'react-native';
import { connect as reduxConnect } from 'react-redux';
@@ -11,6 +12,65 @@ import { JitsiConnectionErrors } from '../../base/lib-jitsi-meet';
import { authenticateAndUpgradeRole, cancelLogin } from '../actions';
import styles from './styles';
/**
* The type of the React {@link Component} props of {@link LoginDialog}.
*/
type Props = {
/**
* {@link JitsiConference} that needs authentication - will hold a valid
* value in XMPP login + guest access mode.
*/
_conference: Object,
/**
* The server hosts specified in the global config.
*/
_configHosts: Object,
/**
* Indicates if the dialog should display "connecting" status message.
*/
_connecting: boolean,
/**
* The error which occurred during login/authentication.
*/
_error: Object,
/**
* The progress in the floating range between 0 and 1 of the authenticating
* and upgrading the role of the local participant/user.
*/
_progress: number,
/**
* Redux store dispatch method.
*/
dispatch: Dispatch<*>,
/**
* Invoked to obtain translated strings.
*/
t: Function
};
/**
* The type of the React {@link Component} state of {@link LoginDialog}.
*/
type State = {
/**
* The user entered password for the conference.
*/
password: string,
/**
* The user entered local participant name.
*/
username: string
};
/**
* Dialog asks user for username and password.
*
@@ -38,58 +98,14 @@ import styles from './styles';
* See {@link https://github.com/jitsi/jicofo#secure-domain} for a description
* of the configuration parameters.
*/
class LoginDialog extends Component {
/**
* LoginDialog component's property types.
*
* @static
*/
static propTypes = {
/**
* {@link JitsiConference} that needs authentication - will hold a valid
* value in XMPP login + guest access mode.
*/
_conference: PropTypes.object,
/**
*
*/
_configHosts: PropTypes.object,
/**
* Indicates if the dialog should display "connecting" status message.
*/
_connecting: PropTypes.bool,
/**
* The error which occurred during login/authentication.
*/
_error: PropTypes.object,
/**
* The progress in the floating range between 0 and 1 of the
* authenticating and upgrading the role of the local participant/user.
*/
_progress: PropTypes.number,
/**
* Redux store dispatch method.
*/
dispatch: PropTypes.func,
/**
* Invoked to obtain translated strings.
*/
t: PropTypes.func
};
class LoginDialog extends Component<Props, State> {
/**
* Initializes a new LoginDialog instance.
*
* @param {Object} props - The read-only properties with which the new
* instance is to be initialized.
*/
constructor(props) {
constructor(props: Props) {
super(props);
this.state = {
@@ -119,7 +135,7 @@ class LoginDialog extends Component {
} = this.props;
let messageKey;
let messageOptions;
const messageOptions = {};
if (progress && progress < 1) {
messageKey = 'connection.FETCH_SESSION_ID';
@@ -142,7 +158,6 @@ class LoginDialog extends Component {
}
} else if (name) {
messageKey = 'dialog.connectErrorWithMsg';
messageOptions || (messageOptions = {});
messageOptions.msg = `${name} ${error.message}`;
}
}
@@ -170,7 +185,7 @@ class LoginDialog extends Component {
<Text style = { styles.dialogText }>
{
messageKey
? t(messageKey, messageOptions || {})
? t(messageKey, messageOptions)
: connecting
? t('connection.CONNECTING')
: ''
@@ -181,6 +196,8 @@ class LoginDialog extends Component {
);
}
_onUsernameChange: (string) => void;
/**
* Called when user edits the username.
*
@@ -194,6 +211,8 @@ class LoginDialog extends Component {
});
}
_onPasswordChange: (string) => void;
/**
* Called when user edits the password.
*
@@ -207,6 +226,8 @@ class LoginDialog extends Component {
});
}
_onCancel: () => void;
/**
* Notifies this LoginDialog that it has been dismissed by cancel.
*
@@ -217,6 +238,8 @@ class LoginDialog extends Component {
this.props.dispatch(cancelLogin());
}
_onLogin: () => void;
/**
* Notifies this LoginDialog that the login button (OK) has been pressed by
* the user.