From 401e5e7ae01ef209a2f4e49a440f182232a03d72 Mon Sep 17 00:00:00 2001 From: isymchych Date: Wed, 10 Feb 2016 17:26:16 +0200 Subject: [PATCH] fix jshint issues --- .jshintignore | 7 ------- modules/UI/UI.js | 4 ++-- modules/UI/videolayout/LocalVideo.js | 2 +- modules/UI/videolayout/RemoteVideo.js | 3 ++- modules/UI/videolayout/SmallVideo.js | 2 +- modules/UI/videolayout/VideoLayout.js | 8 ++++---- 6 files changed, 10 insertions(+), 16 deletions(-) diff --git a/.jshintignore b/.jshintignore index 6224afaa9..efacec50a 100644 --- a/.jshintignore +++ b/.jshintignore @@ -2,10 +2,3 @@ node_modules libs debian analytics.js -lib-jitsi-meet.js - -modules/xmpp/strophe.emuc.js -modules/UI/prezi/Prezi.js -modules/RTC/adapter.screenshare.js -modules/statistics/* -modules/UI/videolayout/* diff --git a/modules/UI/UI.js b/modules/UI/UI.js index 0727e7022..9515dec65 100644 --- a/modules/UI/UI.js +++ b/modules/UI/UI.js @@ -620,8 +620,8 @@ UI.getRemoteVideoType = function (jid) { return VideoLayout.getRemoteVideoType(jid); }; -UI.connectionIndicatorShowMore = function(jid) { - return VideoLayout.showMore(jid); +UI.connectionIndicatorShowMore = function(id) { + VideoLayout.showMore(id); }; // FIXME check if someone user this diff --git a/modules/UI/videolayout/LocalVideo.js b/modules/UI/videolayout/LocalVideo.js index a01c1cde7..e631e6a43 100644 --- a/modules/UI/videolayout/LocalVideo.js +++ b/modules/UI/videolayout/LocalVideo.js @@ -1,4 +1,4 @@ -/* global $, interfaceConfig, APP */ +/* global $, interfaceConfig, APP, JitsiMeetJS */ import ConnectionIndicator from "./ConnectionIndicator"; import UIUtil from "../util/UIUtil"; import UIEvents from "../../../service/UI/UIEvents"; diff --git a/modules/UI/videolayout/RemoteVideo.js b/modules/UI/videolayout/RemoteVideo.js index 99abdaaa1..92462e8d5 100644 --- a/modules/UI/videolayout/RemoteVideo.js +++ b/modules/UI/videolayout/RemoteVideo.js @@ -253,7 +253,8 @@ RemoteVideo.prototype.addRemoteStreamElement = function (stream) { // calling attach will show it back $(streamElement).hide(); - // If the container is currently visible we attach the stream to the element. + // If the container is currently visible + // we attach the stream to the element. if (!isVideo || (this.container.offsetParent !== null && isVideo)) { this.waitForPlayback(streamElement, stream); diff --git a/modules/UI/videolayout/SmallVideo.js b/modules/UI/videolayout/SmallVideo.js index 83cb40ec1..2ea5d87ea 100644 --- a/modules/UI/videolayout/SmallVideo.js +++ b/modules/UI/videolayout/SmallVideo.js @@ -1,4 +1,4 @@ -/* global $, APP, require */ +/* global $, APP, JitsiMeetJS */ /* jshint -W101 */ import Avatar from "../avatar/Avatar"; import UIUtil from "../util/UIUtil"; diff --git a/modules/UI/videolayout/VideoLayout.js b/modules/UI/videolayout/VideoLayout.js index 5a0a81843..53143fd20 100644 --- a/modules/UI/videolayout/VideoLayout.js +++ b/modules/UI/videolayout/VideoLayout.js @@ -819,15 +819,15 @@ var VideoLayout = { } }, - showMore (jid) { - if (jid === 'local') { + showMore (id) { + if (id === 'local') { localVideoThumbnail.connectionIndicator.showMore(); } else { - var remoteVideo = remoteVideos[Strophe.getResourceFromJid(jid)]; + let remoteVideo = remoteVideos[id]; if (remoteVideo) { remoteVideo.connectionIndicator.showMore(); } else { - console.info("Error - no remote video for jid: " + jid); + console.info("Error - no remote video for id: " + id); } } },