From 2101f70a09afbfdb73cf8252d9a3deaf4031973f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sa=C3=BAl=20Ibarra=20Corretg=C3=A9?= <saghul@jitsi.org>
Date: Wed, 19 Sep 2018 16:20:20 +0200
Subject: [PATCH] =?UTF-8?q?cleanup:=20remove=20no=20longer=20used=20code?=
 =?UTF-8?q?=20=F0=9F=94=A5=F0=9F=94=A5=F0=9F=94=A5?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The code for handling device availability has been disabled for a long time,
plus it's ill named since it represents 2 abstractions: lack of permissions and
lack of devices.

Time for it to rest in the git graveyard.
---
 conference.js                         |   7 ----
 css/_videolayout_default.scss         |  24 -------------
 images/noMic.png                      | Bin 2880 -> 0 bytes
 images/noVideo.png                    | Bin 2911 -> 0 bytes
 modules/UI/UI.js                      |   3 --
 modules/UI/videolayout/SmallVideo.js  |  47 --------------------------
 modules/UI/videolayout/VideoLayout.js |  20 -----------
 7 files changed, 101 deletions(-)
 delete mode 100644 images/noMic.png
 delete mode 100644 images/noVideo.png

diff --git a/conference.js b/conference.js
index 528848592..1559d29c4 100644
--- a/conference.js
+++ b/conference.js
@@ -2033,13 +2033,6 @@ export default {
                 && APP.UI.notifyInitiallyMuted();
         });
 
-        room.on(
-            JitsiConferenceEvents.AVAILABLE_DEVICES_CHANGED,
-            (id, devices) => {
-                APP.UI.updateDevicesAvailability(id, devices);
-            }
-        );
-
         room.on(
             JitsiConferenceEvents.DATA_CHANNEL_OPENED, () => {
                 APP.store.dispatch(dataChannelOpened());
diff --git a/css/_videolayout_default.scss b/css/_videolayout_default.scss
index 263d21d4e..314ada813 100644
--- a/css/_videolayout_default.scss
+++ b/css/_videolayout_default.scss
@@ -557,30 +557,6 @@
     object-fit: cover;
 }
 
-.noMic {
-    position: absolute;
-    border-radius: 8px;
-    z-index: $zindex1;
-    width: 100%;
-    height: 100%;
-    background-image: url("../images/noMic.png");
-    background-color: #000;
-    background-repeat: no-repeat;
-    background-position: center;
-}
-
-.noVideo {
-    position: absolute;
-    border-radius: 8px;
-    z-index: $zindex1;
-    width: 100%;
-    height: 100%;
-    background-image: url("../images/noVideo.png");
-    background-color: #000;
-    background-repeat: no-repeat;
-    background-position: center;
-}
-
 .videoMessageFilter {
     -webkit-filter: grayscale(.5) opacity(0.8);
     filter: grayscale(.5) opacity(0.8);
diff --git a/images/noMic.png b/images/noMic.png
deleted file mode 100644
index 287fd286bb4fe8153e815314a8318342a9e6a1d0..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 2880
zcmbVOdpwi-AD>GlDRKNLg_*nGY<o6_xsGjZn3#nWnr&Fw#x{mjqFhhz*Hdy&r$Wc2
zPKBggigKq^!jW4=C5aq<Q#rriALn)c_&u-ZdA{H0`+VN-&--)vzMd!E$#LIyX=P~;
z2(+C<#8E^eQgi`Qn??7WtIKMlVYdM9E^y)c3WPKs6NF`OeVAYpo94%)FlmgipodIz
z5J<wGMRgarlN~U0E*nN$w}FMS14U>M$lNM4kVZeo6o7r0ek_g!WbV#g2$;pNfVdfv
z5#&Hyray}q&SScSJ5uT4$LOXEh?OPSJQO1$U^4|Ya40)~!^ebLK)&%}MDz7!I0XF7
zL~zUk@?DfW*$HgR<uSoVFq8ou0RUh$8U`2|q0s;oj6?uPI6`!y4FE%o5gLOu2LCu9
zB5yo~FNT66{O~1uvViyt1c4YhTqqR6geVx7=LZK&O-<K1kVpfOg#kZ|BcO#EaQGS<
z3^*pA&SM1%SX>Txoss6l4Hj5HL`uJhzz!sn|03q_e<VtjGI%I05Dvf)a5j5Au5Z?S
z0fqTr8Gmcdr-lVG;S?sH8_c7N>fx)g0T$)%pB=3miqv5C^H`#y&;oE=dN7;G5s+{e
z5YZbLgT=rAw#IlvBnnRekS1so05Cx!u~;JjXNa;jHAWbtH#q(dYlAh!+lq2-YXgWX
zfj2ZknF3f7V;iKQjS<!chu^@GID7$(LuYRIWr_U$zykk>#n|$gGy#`K<#GcyI>5=F
zE8z0|xq)C?7c^LxOrx_n>kE481^ON@j>%(%Fc}0Mmks`wVGQeU6d+J0BGtx*2xBDT
zTjU566agUM0R#?@MjIg@Kd_AdCu?w#82Ea7{7<`VEQxw>efn4Piyr>kK1_~i&+tT>
z<F;D!3<$J^L&9OHp+kKh+nlHeb`5)WD>z?E>1#Ap%aw4=k@%w77s0S>X>~|)&qDc1
zIis_d_G*>yZm;TS`L%5y*%gV~Z0ZQt>Pb7$SOWrFTw0;deNIZtC%-1I9-bSnU!1LI
z&Rv>#VX;`(@HKzUYHg_#^JZpduVY#7D0gU9ikkqHBZ~V(R#+=^iTg|TiTg!rSns~B
z^hH_MA&{CkFN`R&!XcJ+GHfFsHWCYdJ;#B8!WxwyVP~3xHN?fqDW#z5(~e$O`azk{
zv-1vVCB1U~6Qz&UkLaarvN^RSQ;Mjmaa`hem-!i4aCUaPuo3HU$+gU4`+zDDly)$U
zZP-60QBruqt1<rijyh?F-nwN)_b2URMdx0VmiboiHQ_F~0}{R6++gdtBiEm&G9`rZ
zV``ByG9T+TthfI0K>d)|C%NXkpkm-jCxPv$jhQ=r%{rx^)+`!I1(Qr*m9_fD_U@O=
zBH20n>e%s!c(%1YOn*y@Pa|dDPWhHSNpJbi0%`x|P6lH3{!=q3Nir|QItxx*Awpy!
z@z33Ls2G_~k~cnbs|4qrD$lbZmm?(J;LKn{TV*8Ue{$84ijNg%S))^A8RE{Ei52<?
z0R|}s#QsQKP;R*zMUhO2UZ(kKeMAPzTFq^VDegs~iCq_+JEYAw?~?8i`#k#c$m7uZ
z2XhDQ)<OqQ?fgQT>d?=}h~GHTtW-cY5X*aa0~=*2Up{%fo@z=?9~uoX0xiWBMQ9*Y
z=>x11f@DJE#9>33;D)YDsXKeQ2}P4{Q%3q;MM{=V=nQhEVprJCu43j_wC<&;qb|S_
zT&tv~VC7q_p;kYg9{jWG)vn^~i!;@U`l=VvYRR;wYw37%b{90UezRT8P4cZ6si)oZ
zhr6fr1T!C^iE;Pt)a8x7Gh?+~@~M+o`zk}yw^evNae%rXB5`J|M&evUkfe@^{&Y7t
zv3LM=Frz;9!?4jUR@$bQ9aazh_7rMC%)C@J<(2kd^D>)^U`;0${rtI92l~0%#=PvX
zdQ;N#T{JS!z~l0;^;Rbt&CsjDX=?w<Bi8h`50^7C9G0Jcx$R=m&Dj<R$~o#oOlu1|
zc@i`)dqBQW#qdJ@yn4gD;@z%e0h;0OtG$LqU%A*&S4w7^P3rS`8H5y=J7$o=8l{JY
zJ!rj@+;d2dB)`y5^Bcn>aq^I0*ll+91z!ng?2#6$iJqw`>kq1q2kxdVm&XYzZ{|s&
z`}ZEKfmZvjt)AumJk>nkX7l7@vG;UX>zO$At9xQmRgp&*M_)~<dZpZQ&-o+0#=G{s
z87e(H?d7LE#~+M4ggDEy+LxTK-Bq@lJlQWlFmQ4tY1Xl<;ZUY0NSj7l82hO(*P_*b
zziFdYF?EYw_tgMLuNXeWM0lr|PV&}H5axohkKQRNrcp|;rwAm|Dw?{@eCF2x9hHBb
zXQABlb_8xFjd$8<^sw!p*#8o(d~3n+@ec3%?VS#k)GPw5JBLC)j|&<2>hSzVZ%<f$
z-7&1d=SzWRn7OW`rO#wlx&Lg8F=xPtBL4n&Lwo%f+Nqrt0ZFR+2ZmQ|^A)u-w2j2<
zk6w>!jA*LZlsm-yrNOcmQIQr<Yaj7jyB*w<-V11zRY%G?HP5zHOq%#=C5vy`8?ncJ
z4`e2}?A*ouXM6gsw&i@hWnwwttdi&n883o5x}B$xuI7CDVwSyXo~!?eH<pxL3CX)R
zepCF}TDW2Gbi~-6U#IC}GdUKHH<jetd8KcU<IjeMj6=0_7lA6fU;IZiT2jlW3(&jM
z-GG<cUbowBOkLAXn6$8i^f1*J8sa@a51z26nYY-&Teeo-ju+eN;V6q$u2qa7XLUQ`
zONhEFh#kouq<=r7QT0?buaGYw7D2_<Bfv=1S=m7%)c&a3l>9Iw>AGYwRInUp&V!WO
zp1KPBh8&hzKpPKb_QsjdydLUmRc|tViAz-syY8WJ5#^8;*MG*BICyD(w^o+K?!xex
zqy<_L`936i=bIWGT*9qcmkJr}-0^7KHrK98O#;gM5h(G@hp@tP$*4b-i=%V0gN|b=
z2=5-2aIfq;Gl%p_Y4!9<B*>k6GPX#S1M+D-)upT19^lcwy)Uwkbl8WF7Hn_&H2nCD
zd*ywZ;TILUW|$1@jUYu!o_vWstqL~nqedI94%nys!Sb|3`y+VqNQigXVyvaChd{X5
zX9wQ0q<hmdm>jDF!D(=Vyojq9py1zT&)PT^m`8cO_dmI)v@=$C7Za6(fSt$?AJwXC
z&C&CXdWw1`EW(|xF`o^n2M3ud@KuOssz&4FX8S%J>nOOHsM?^WrvO90bZdJPSqlEJ
z5}bmA-C53<YO2j2HoDM0qD%4)ziiTsXE`j?fzzj&+DWMe^Gi}(VLVK2a!h`9D#zDt
zxFZZ9W%BG$VB%|B+WYW#6X{avdcNsy`XR5i6q4>m#*1mowJN4|9L?#9UnOYD1mpa6
z79aoYW@59n*5EfNbD?9n;xna+wla@J<;JXeD{L=}`Ew2|p|ae$TDg!6k^l`7+KXU^
S#yi*lX-RlTT!qb%sQ&;<_QqrY

diff --git a/images/noVideo.png b/images/noVideo.png
deleted file mode 100644
index 91cd97b19cd1d362256ecd51ce0274ba13cc9e25..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 2911
zcmbVOX;c&E8ctY)tZvAvV~iA(kW9!9NFWIWD@GPAA}Ar5kN{ao0%1`|6h%;kia|wC
zz=g%CfT&ebz!q6Vu!w?!s0fI4DK1ojiZ{6Q-XA^vap%m;x6J!I@AEF-Ig`0&wXf+c
zn^`az%+!y?2-J??%!4q{zU75pcG|&O!3<FZN%#sSM+U*Xc#=p6@Dp*Opg@SjONwiS
z++i?XfiO5k5#qm!%9V&*I5Rdbi6W^M4THIRCQ3Qn7)Sv`LQz7o2l9{0^+-U-^FaPU
z@W=W~>5xFkN|r%E$*Y68$uV3C59zrAa8IOa2}F>B10;%K#d2z*2l6v7RXd;A#vp;u
zCW;sj<QGvP{%ZibL<Ru_7gsbF3xWWV=mO#iL?Y-6;IJSLgVo+dG>E4Xh*TU2_<A9=
z-ef#JHIU)+)t7eVffOhdQYr?cR4QGRt}YT;6b7VFC^H;599nCEmM4i7oJ6!(zT_JN
z1Cn!PLa9P15d$-foJdK$!UL&Q`XvOB)ZhPaVzK;dqO>W)Byyw}&;^STiDu&ZY%Ny=
zLjRTVkJj?wBq@XmgyfQV8CP2m{*rHCZSMZv(Tt&14V5huYKy{&Wk|U3B1o+8V|XC7
zUtD-X9u=gMn0TBk(+9+niDVEY<8WSH1dxGurBg^)67d_yKVb=UFD3;`B+$J<Z6%m^
zvMUAjB9pvvcyEH2H-q^N>nD~gIASjJ&96}F_bV3vuUINw25}S;S+GPB`>g}k2qX%L
zTp*DG^dKVO=+EH_#WNdDGX?q*F9VVZ6Cj?COd<k4XP7Gd2L)JHvQ{+-k0s%-pCiYT
zU41|wCWvJ)i9`Yx`4!9if3k+riowjZ$N#j;w=HcC&P@Mqe(mD#;{%DcXGW$y93wvC
z$uO8<wjaYQIPrdWs8MV%(`w+TCJT+e9}V-;JH}cZQ8A1aFdZZGvr1?saHPXl6nY2D
z(p<;pl)(~T%DjE_rCS#hLy+?s2-f^iv*W64G`gk4*|!8Cx)5HU_Llu&YP00R)Ie9d
z=LAmj^a{!K;h|3j2ha6w1?qc|8%nKU?#2qkOFA!Ahz5AKZjZWN75K=i%GU8k)X7WG
zxwOmM)fuHMxI<i0P9}e6gR&vH7?$3D(_3eoIUUqLU|35^eBmI?s$XIHZsTFiYMSvj
zWt++_Lbs)R0GtD0?U*j+K5Y*h)<rC+KuB$LUys(YE5~=Pxe`FD9jVT1FsZ9wUXHqz
zM9$LCc8sipSM6I{GH`5VS4NU4tE+#bDX-+gp?tsMqhiN5s*r#y<_9v(vP52U-kr_A
z6FiHe3K%Wx#~b1M7cj3Lcw<X*s9MJkceY^pREO`*;NNNOS)k&K{vl{U9cW<3?n5nY
zu)-&FSu(slMFDp3$e(|A&NbU?;C?;6N2MN}y5Nu(G5`K@zUs7Z@sE|jTxpGKVrV;U
z&g8v}6h^e|80w*$x%>8%vf7tqlig%CJtCyasLI(wk2QeOQK;V_v!1GuS9=UTSU!n)
zyk9S6G4yM5lEJj;pQHE8MlzSxWSS4Tj_x09e``l)CBqj@1b>HjH)(o*ZRgx$ritzg
zv)c01Uf0&?Xyi@5h0FT)hcRv3MzgPm8KkGA?CMj?iVLcJP-B4USUQ3i^!m}$tuWJM
z!)M308wtwKTm_FgmOk+QZBL)IHNo+5G!t|A!QtoJ5q{~118LJ{zn;W1D{p_lwV`v!
zhw!rfJWIt}fk4IFZ#95-eS|)&S+b?>^6o2Ee(Z>_qX%I(Ebd-53p;|yH-wBwRVV6m
z^mW|KcAQ(^zeX-URDOf~lN?>0kv?zCFg)kpfk7^DZ|}>#keK9%Lepr6Ks~h%8lEpO
z*6TRZnyNHI#9G8hQBQRgnd)qsmA$ho#d=YdM{akIJl?a<p!G?EYhaN>rZV54al%gL
z>WJ#x+=SdXm#Ep#rgX2Fb#XU#gzR~qv6+zGSiiNjFiKUE(KJY;SZ_dJ1c3}<Xar|$
z2r-~u87$}qe4EX7RPBGuR0S3;EnPO-s&#hV{M?oB+l|6%S@?#Vyra3)2zLX|wHYv|
zLQY7a8BFFc(m4}@DDRE?K3&bK3CeJYe1)Uv9<=()0aQr=Grg9MtGNlZWiYo8k%eHX
z`u&!77lOjR3!r;2m?cI!Q(h4os|I}Nyo)DK2LOGj7b<>?^VK2f{QM<4#vd(!iM3%$
z<yh%Pv=jRf@Z)lW+z#Q5jHUqljbk0tqJz3RZD)T1p4=5Kzjvgd`WBzAyQz6jX2wLb
zQ(jEEeL=c-N}VfcyU5R+bnk5hbL%>73tuD@WdA}H5u7xQ<QVeFafclYWMNtu>FfqI
z{Ng_QV!`@@nxdB#$}@92gB8=!H?=^YJ+&*Bp)bX0)}}0YwYqxCoN_Xls7bqX>CC$9
z`YOfJil7+Cu;cFgGGDgU*{r-Pwu29(yHLOXY!YO<VPKJi&8)S=?ba1&@kdtWU9&kZ
z`^#z!e;T?|vR7>BmtL8}MpaJurng?dE_1hf?dc}nv~1YQ%g5c6VH+|&7@(+SAp<Kk
z+b&r8Eo`E-zd-D{o?@T0;7qkWx#-BFN#6n^i(Z#k7`$MY$-o);<2&KDn*EgCaHq~&
zi)lKqs69*D-ja;niXU8#1Lxje9r5U;x{+4mpkaXm38rlRbpEw)W|eci;9YH+3RPp?
zq(}{L9`WNh>My)y6uG#eFS&wo^!SMfhdU{OnK{jqS<mMnt9^q_W~pck2jS5E^`&Ct
zu3_)4B)|lrPlex3BAhSw>)V@<;^ejyZIEMP*^{zUZ+Mgt2JXEO@RuL+-p~&VfQ2pZ
zO5BNQZ#SEzHWk9V-$ceRiw6*lmdD57lAWV<he)*<yFvnn9u=9KyI<O$TK?N)$i&l2
zyH1<*?8rWn#aty4^d-zK4cyy<=&N!D2H^uw07?N48b}u(uT|HGAv@gdcD&#%dw9y+
zqj#x)jN$93@4N8ewcY!yb17y+@OimWSsR`Yx4CRWrO`pih$=#J+{mZ6hMEE^jt^`6
z?uWQjeuMO)TfJxBtA(nJYBq*%mu+jYYjXME#hT?4`f=F)8w+D(`mFH_!$x+NTiD%w
z%IHS7)Js#VHy<ga)qRlZVvX^K;w<@(7G;^Q(L7IO@iNB=q6yEEKa2i)3H!5gTiTdM
zD5>2dhuwT-?RkE#!ymA$1uZSEzb33ej|l@lWhchYwXuG<N-r|8>E3#D`K|XRM>b5=
zE#HVDYK+&1hZ<q#cOJT;ETHL~nbI6B*_NMrpZny*VYXw%W1l_v+a~yDn~}MB$eJH7
z3V2Db7Nf0B854O()7eS<A8s~E!?B$&7->V#96Li%mco(F7x>CMc4cKB?`?O;ihf>J
zX2T^>n@_N&f3YVwpBOE&-Y1XsFH^j$ZBHOgAEmkGUY@GAr&iK#th&Fk%=%KwG{mKq
uJAG1Cj+hPycIYJpxmfQ0<o5Bq1{lf1YF~?6+qIcrUO(n)#%b?}t^Wav?5~Xg

diff --git a/modules/UI/UI.js b/modules/UI/UI.js
index d8c14d515..7ccc9b14c 100644
--- a/modules/UI/UI.js
+++ b/modules/UI/UI.js
@@ -298,9 +298,6 @@ UI.start = function() {
     } else {
         // Initialize recording mode UI.
         if (config.iAmRecorder) {
-            VideoLayout.enableDeviceAvailabilityIcons(
-                APP.conference.getMyUserId(), false);
-
             // in case of iAmSipGateway keep local video visible
             if (!config.iAmSipGateway) {
                 VideoLayout.setLocalVideoVisible(false);
diff --git a/modules/UI/videolayout/SmallVideo.js b/modules/UI/videolayout/SmallVideo.js
index 7a3283ed9..fab159a7a 100644
--- a/modules/UI/videolayout/SmallVideo.js
+++ b/modules/UI/videolayout/SmallVideo.js
@@ -162,53 +162,6 @@ SmallVideo.prototype.isVisible = function() {
     return this.$container.is(':visible');
 };
 
-/**
- * Enables / disables the device availability icons for this small video.
- * @param {enable} set to {true} to enable and {false} to disable
- */
-SmallVideo.prototype.enableDeviceAvailabilityIcons = function(enable) {
-    if (typeof enable === 'undefined') {
-        return;
-    }
-
-    this.deviceAvailabilityIconsEnabled = enable;
-};
-
-/**
- * Sets the device "non" availability icons.
- * @param devices the devices, which will be checked for availability
- */
-SmallVideo.prototype.setDeviceAvailabilityIcons = function(devices) {
-    if (!this.deviceAvailabilityIconsEnabled) {
-        return;
-    }
-
-    if (!this.container) {
-        return;
-    }
-
-    const noMic = this.$container.find('.noMic');
-    const noVideo = this.$container.find('.noVideo');
-
-    noMic.remove();
-    noVideo.remove();
-    if (!devices.audio) {
-        this.container.appendChild(
-            document.createElement('div')).setAttribute('class', 'noMic');
-    }
-
-    if (!devices.video) {
-        this.container.appendChild(
-            document.createElement('div')).setAttribute('class', 'noVideo');
-    }
-
-    if (!devices.audio && !devices.video) {
-        noMic.css('background-position', '75%');
-        noVideo.css('background-position', '25%');
-        noVideo.css('background-color', 'transparent');
-    }
-};
-
 /**
  * Sets the type of the video displayed by this instance.
  * Note that this is a string without clearly defined or checked values, and
diff --git a/modules/UI/videolayout/VideoLayout.js b/modules/UI/videolayout/VideoLayout.js
index fd97dc740..b64dd9105 100644
--- a/modules/UI/videolayout/VideoLayout.js
+++ b/modules/UI/videolayout/VideoLayout.js
@@ -230,26 +230,6 @@ const VideoLayout = {
         video.setDeviceAvailabilityIcons(devices);
     },
 
-    /**
-     * Enables/disables device availability icons for the given participant id.
-     * The default value is {true}.
-     * @param id the identifier of the participant
-     * @param enable {true} to enable device availability icons
-     */
-    enableDeviceAvailabilityIcons(id, enable) {
-        let video;
-
-        if (APP.conference.isLocalId(id)) {
-            video = localVideoThumbnail;
-        } else {
-            video = remoteVideos[id];
-        }
-
-        if (video) {
-            video.enableDeviceAvailabilityIcons(enable);
-        }
-    },
-
     /**
      * Shows/hides local video.
      * @param {boolean} true to make the local video visible, false - otherwise