From 73cc3170f4367e7a707ea2c3d024eb69138ca402 Mon Sep 17 00:00:00 2001 From: Jens Steube Date: Tue, 20 Apr 2021 17:14:13 +0200 Subject: [PATCH] Fixed both false negative and false positive result in -m 3000 in -a 3 (affected only NVIDIA GPU) --- OpenCL/inc_platform.cl | 10 +++++++--- docs/changes.txt | 13 +++++++------ 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/OpenCL/inc_platform.cl b/OpenCL/inc_platform.cl index 768de504a..cc08a2392 100644 --- a/OpenCL/inc_platform.cl +++ b/OpenCL/inc_platform.cl @@ -87,15 +87,19 @@ CONSTANT_VK u32 generic_constant[8192]; // 32k DECLSPEC u32 atomic_dec (u32 *p) { - return atomicSub (p, 1); + volatile const u32 val = 1; + + return atomicSub (p, val); } DECLSPEC u32 atomic_inc (u32 *p) { - return atomicAdd (p, 1); + volatile const u32 val = 1; + + return atomicAdd (p, val); } -DECLSPEC u32 atomic_or (u32 *p, u32 val) +DECLSPEC u32 atomic_or (u32 *p, volatile const u32 val) { return atomicOr (p, val); } diff --git a/docs/changes.txt b/docs/changes.txt index 5bd2b8745..ff94f3a02 100644 --- a/docs/changes.txt +++ b/docs/changes.txt @@ -40,14 +40,15 @@ ## Bugs ## -- Fixed too early execution of some module functions which could make use of non-final values opts_type and opti_type -- Fixed internal access on module option attribute OPTS_TYPE_SUGGEST_KG with the result that it was unused -- Fixed race condition resulting in out of memory error on startup if multiple hashcat instances are started at the same time -- Fixed unexpected non-unique salts in multi-hash cracking in Bitcoin/Litecoin wallet.dat module which lead to false negatives -- Fixed rare case of misalignment of the status prompt when other user warnings are shown within the hashcat output -- Fixed password reassembling for cracked hashes on host for slow hashes in optimized mode that are longer than 32 characters +- Fixed both false negative and false positive result in -m 3000 in -a 3 (affected only NVIDIA GPU) - Fixed incorrect maximum password length support for -m 400 in optimized mode (reduced from 55 to 39) +- Fixed internal access on module option attribute OPTS_TYPE_SUGGEST_KG with the result that it was unused - Fixed invalid handling of outfile folder entries for -m 22000 +- Fixed password reassembling for cracked hashes on host for slow hashes in optimized mode that are longer than 32 characters +- Fixed race condition resulting in out of memory error on startup if multiple hashcat instances are started at the same time +- Fixed rare case of misalignment of the status prompt when other user warnings are shown within the hashcat output +- Fixed too early execution of some module functions which could make use of non-final values opts_type and opti_type +- Fixed unexpected non-unique salts in multi-hash cracking in Bitcoin/Litecoin wallet.dat module which lead to false negatives ## ## Improvements