From 05a38a42b7e4154ab893563a1b3818f34e04bd9a Mon Sep 17 00:00:00 2001
From: jsteube <jens.steube@gmail.com>
Date: Fri, 5 Apr 2019 12:20:36 +0200
Subject: [PATCH] Initialize some values to make scan-build happy

---
 src/modules/module_05500.c | 8 +++++---
 src/modules/module_06400.c | 3 ++-
 src/modules/module_06500.c | 2 +-
 src/modules/module_06700.c | 2 +-
 src/modules/module_07900.c | 4 ++--
 src/modules/module_15100.c | 2 +-
 6 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/src/modules/module_05500.c b/src/modules/module_05500.c
index 4d39507d0..4f001d41c 100644
--- a/src/modules/module_05500.c
+++ b/src/modules/module_05500.c
@@ -257,10 +257,12 @@ int module_hash_decode (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSE
 
   for (u32 i = 0; i < 0x10000; i++)
   {
-    u32 key_md4[2] = { i, 0 };
-    u32 key_des[2] = { 0, 0 };
+    u32 key_md4[2] = { 0 };
+    u32 key_des[2] = { 0 };
 
-    transform_netntlmv1_key ((u8 *) key_md4, (u8 *) key_des);
+    key_md4[0] = i;
+
+    transform_netntlmv1_key ((const u8 *) key_md4, (u8 *) key_des);
 
     u32 Kc[16] = { 0 };
     u32 Kd[16] = { 0 };
diff --git a/src/modules/module_06400.c b/src/modules/module_06400.c
index 3ef92f040..998cf2447 100644
--- a/src/modules/module_06400.c
+++ b/src/modules/module_06400.c
@@ -155,6 +155,7 @@ static void sha256aix_decode (u8 digest[32], const u8 buf[43])
   digest[31] = (l >>  8) & 0xff;
   digest[30] = (l >> 16) & 0xff;
 }
+
 static void sha256aix_encode (const u8 digest[32], u8 buf[43])
 {
   int l;
@@ -352,7 +353,7 @@ int module_hash_encode (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSE
 {
   const u32 *digest = (const u32 *) digest_buf;
 
-  u32 tmp[8];
+  u32 tmp[8] = { 0 }; // this (useless?) initialization makes scan-build happy
 
   tmp[0] = digest[0];
   tmp[1] = digest[1];
diff --git a/src/modules/module_06500.c b/src/modules/module_06500.c
index f094f84a6..bf4bf7dda 100644
--- a/src/modules/module_06500.c
+++ b/src/modules/module_06500.c
@@ -495,7 +495,7 @@ int module_hash_encode (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSE
 {
   const u64 *digest = (const u64 *) digest_buf;
 
-  u64 tmp[8];
+  u64 tmp[8] = { 0 }; // this (useless?) initialization makes scan-build happy
 
   tmp[0] = digest[0];
   tmp[1] = digest[1];
diff --git a/src/modules/module_06700.c b/src/modules/module_06700.c
index 962367a3c..6fd4c80d3 100644
--- a/src/modules/module_06700.c
+++ b/src/modules/module_06700.c
@@ -254,7 +254,7 @@ int module_hash_encode (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSE
 {
   const u32 *digest = (const u32 *) digest_buf;
 
-  u32 tmp[5];
+  u32 tmp[5] = { 0 }; // this (useless?) initialization makes scan-build happy
 
   tmp[0] = digest[0];
   tmp[1] = digest[1];
diff --git a/src/modules/module_07900.c b/src/modules/module_07900.c
index fe82989ae..a8d9746ee 100644
--- a/src/modules/module_07900.c
+++ b/src/modules/module_07900.c
@@ -403,7 +403,7 @@ int module_hash_encode (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSE
 {
   const u64 *digest = (const u64 *) digest_buf;
 
-  u64 tmp[8];
+  u64 tmp[8] = { 0 }; // this (useless?) initialization makes scan-build happy
 
   tmp[0] = byte_swap_64 (digest[0]);
   tmp[1] = byte_swap_64 (digest[1]);
@@ -416,7 +416,7 @@ int module_hash_encode (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSE
 
   char ptr_plain[128] = { 0 };
 
-  drupal7_encode ((unsigned char *) tmp, (unsigned char *) ptr_plain);
+  drupal7_encode ((const u8 *) tmp, (u8 *) ptr_plain);
 
   // ugly hack start
 
diff --git a/src/modules/module_15100.c b/src/modules/module_15100.c
index 43bb78c88..017ac67b5 100644
--- a/src/modules/module_15100.c
+++ b/src/modules/module_15100.c
@@ -279,7 +279,7 @@ int module_hash_encode (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSE
 
   // encode the digest:
 
-  u32 tmp[5];
+  u32 tmp[5] = { 0 }; // this (useless?) initialization makes scan-build happy
 
   tmp[0] = byte_swap_32 (digest[0]);
   tmp[1] = byte_swap_32 (digest[1]);