390 Commits

Author SHA1 Message Date
f00d44deac Seed random() at least a bit before using random()
In fwknop, the values generated using random() are only used for the ID
field of raw IP packets. As indicated in the corresponding comments,
this value does not really matter, and it does not really have to be
random at all.

However, it should not hurt to initialize the entropy pool before
generating random values. arc4random() would be a better choice, but it
is not portable across the range of systems currently supported by
fwknop.
2018-08-06 19:20:35 +02:00
Michael Rash
ae089b1bad
Merge pull request #280 from DeforaNetworks/khorben/connect-error-format 2018-07-25 18:42:29 -04:00
6d6a722128 Fix incomplete format string upon errors 2018-07-25 22:35:03 +02:00
8a1289cdc9 More consistent usage screens 2018-07-17 16:45:46 +02:00
5228fe88d0 Avoid compilation warnings from ctype(3) helpers
Characters should be casted as unsigned before use in functions from
<ctype.h>. Otherwise the compiler treats 8-bit characters (eg UTF-8) as
negative values (since it expects signed integers) and they no longer
match the comparison tables. Worse, the character 0xff gets interpreted
as -1 (like EOF). In turn, it helps to explicitly cast the result as a
signed integer, since this is what is expected. Characters in the range
0x80-0xff do keep their original values.

See the manual page for ctype(3) for more details (eg from NetBSD)
2018-06-12 14:01:22 -04:00
1062021957 Fix typo in a comment 2018-04-25 03:48:24 +02:00
Michael Rash
2c5d7597a9 [client] minor comment update 2016-10-11 23:12:22 -04:00
Michael Rash
c06e8baa7e [client] exit() upon execvpe() error for wget execution 2016-10-11 23:04:25 -04:00
Jakub Wilk
2d7f5132aa Fix indefinite articles 2016-09-06 12:20:39 +02:00
Markus Gerstel
ea23648d02 Fix spelling error in documentation
Original patch by Franck Joncourt <franck@debian.org>
2016-08-22 22:05:06 +01:00
Michael Rash
779029e8bb doc update 2016-06-08 20:38:40 -04:00
Michael Rash
ae417e43bb recognize Jonathan as a core developer 2016-06-06 20:23:46 -04:00
Michael Rash
5f15119190 clarify GPL v2+ for the license per issue #222 2016-06-03 22:08:15 -04:00
Michael Rash
919156fdf0 apply doc updates to man pages 2016-05-28 09:29:34 -04:00
Michael Rash
74ddbf63b2 minor documentation updates 2016-05-27 23:15:39 -07:00
Jonathan Bennett
74d3515218 Removes a dead code path in client
A trio of checks were done two places, and the code path always went through both checks.
Since the program announced a fail and closed, the second set of checks could never be triggered.
2016-05-26 09:32:26 -05:00
Jonathan Bennett
ce0def7e18 Client: Only dump SPA data twice when --test and --verbose are used 2016-05-20 21:42:46 -05:00
Michael Rash
8334473887 Merge pull request #219 from oneru/test-suite 2016-05-14 23:19:17 -04:00
Jonathan Bennett
f50b5c6e99 Tightens nat access validation in client 2016-05-14 00:47:05 -05:00
Michael Rash
60a9cc203b Merge branch 'master' of ssh://192.168.10.1/home/mbr/git/fwknop 2016-05-11 22:05:20 -07:00
Michael Rash
ba5f5e2424 add sha3_256 sha3_512 to man page docs 2016-05-12 22:23:54 -04:00
Jonathan Bennett
dc9ad5de4a Adds a length modifier to is_valid_ipv4_addr 2016-05-07 21:59:48 -05:00
Michael Rash
d4ec9a0755 remove execute bit from file permissions 2016-05-07 09:14:30 -04:00
Jonathan Bennett
58bce15b1e Exclude the CUnit tests themselves from lcov 2016-05-02 13:17:03 -05:00
Jonathan Bennett
f0ca6fc4b2 Adds linking order magic to fix compiling CUint and libfiu together 2016-05-02 11:40:09 -05:00
Jonathan Bennett
a554f0d685 Disable ipv6 dns resolution in the client 2016-04-24 21:51:13 -05:00
Jonathan Bennett
e357b04ff5 Corrects a problem where the NAT Access string was incorrectly set in some cases 2016-04-10 17:06:38 -05:00
Michael Rash
6436235baf client man page update 2016-04-10 16:01:59 -04:00
Michael Rash
5e7871c9c6 Merge pull request #208 from oneru/master 2016-04-10 13:30:46 -04:00
Jonathan Bennett
d939deb811 Spelling corrections, found using the codespell tool. 2016-04-10 12:03:59 -05:00
Michael Rash
eb94f19d8f [client] add --no-home-dir and --no-rc-file, closes #203 2016-04-09 21:17:10 -04:00
Benjamin Ryzman
fac10925d1 Fix client/Makefile.am to work with libtool 2.4.6 from Cygwin 2016-02-14 11:29:41 +01:00
Jonathan Bennett
abd895c522 Removes unused string from set_nat_access 2016-01-11 00:11:46 -06:00
Jonathan Bennett
a3e0d1cc1b clean up whitespace problems 2016-01-02 20:18:12 -06:00
Jonathan Bennett
9475b625a0 Add Doxygen headers to client files 2016-01-01 02:13:21 +00:00
Jonathan Bennett
dda7fa39c1 Disable client side nat_dns 2015-12-31 19:24:45 +00:00
Jonathan Bennett
bc55f0f21f Add count_characters and a CUnit test series for it. 2015-12-31 04:14:58 +00:00
Jonathan Bennett
d9f9cb8ad5 Add SHA3 and HMAC-SHA3 support 2015-12-30 20:32:52 +00:00
Michael Rash
e3ae6747d9 doc updates 2015-12-24 16:08:35 -05:00
Michael Rash
a85b081f79 copyright update 2015-12-23 14:34:51 -05:00
Michael Rash
9c54d774f6 [docs] man page updates 2015-12-23 11:47:17 -05:00
Michael Rash
2fad399db3 promote hex_dump() to fko_util 2015-12-16 19:28:10 -08:00
Michael Rash
998fb96f0b promote argv handling functions to fko_util (avoids duplication across client and server) 2015-12-16 18:59:10 -08:00
Michael Rash
f230c32371 promote chop_* functions into fko_util 2015-12-16 18:00:57 -08:00
Michael Rash
a000bcd4a0 [client] minor formatting update 2015-12-04 18:49:24 -08:00
Michael Rash
97faa2dbdf minor docs update 2015-11-10 21:40:57 -05:00
Michael Rash
b03c007c44 [client] add --server-resolve-ipv4 to only accept IPv4 addresses from DNS for the SPA server 2015-09-27 10:17:36 -04:00
Damien Stuart
a4309ad768 Added clean up for .gcno and .gcda files (left went c-unit-tests are enabled. 2015-09-05 15:20:22 -04:00
Damien Stuart
2e60687dcf Merge branch 'master' into dstuart_refactor_autoconf 2015-08-29 12:46:24 -04:00
Michael Rash
ecfa8021e5 doc updates to include sudo information 2015-08-24 17:25:06 -07:00