1064 Commits

Author SHA1 Message Date
Michael Rash
8c09d38941 various sizeof() usage and type bug fixes found by Coverity 2013-05-09 21:17:27 -04:00
Michael Rash
b92f892ae0 [test suite] minor bug fix for printing the number of test buckets to be executed 2013-05-09 21:11:45 -04:00
Michael Rash
9f9bbcbcdd fixed several resource leak conditions found by Coverity 2013-05-09 17:15:58 -04:00
Michael Rash
aaa28d4ab3 [server] double free bug fix in access.conf parsing routine caught by Coverity 2013-05-08 23:44:13 -04:00
Michael Rash
3a1efd9321 [server] fixed several (non-exploitable) overflow conditions found by Coverity 2013-05-08 23:29:06 -04:00
Michael Rash
8d980ae686 remove dead code caught by Coverity 2013-05-07 23:02:49 -04:00
Michael Rash
50f0ee2f7d [server] bug fix for GPG 'nesting level does not match indentation' issue (discovered by Coverity) 2013-05-07 22:53:20 -04:00
Michael Rash
e1c6f04ef9 [client] fix missing 'break' in switch statement (discovered by Coverity) 2013-05-07 21:43:38 -04:00
Michael Rash
8f423e8b89 [server] added --pcap-any-direction along with config file support
From the config file comments:

This variable controls whether fwknopd is permitted to sniff SPA packets
regardless of whether they are received on the sniffing interface or sent
from the sniffing interface.  In the later case, this can be useful to have
fwknopd sniff SPA packets that are forwarded through a system and destined
for a different network.  If the sniffing interface is the egress interface
for such packets, then this variable will need to be set to "Y" in order for
fwknopd to see them.  The default is "N" so that fwknopd only looks for SPA
packets that are received on the sniffin

PCAP_ANY_DIRECTION         N;
2013-05-06 22:23:59 -04:00
Michael Rash
5aac3d978c minor typo fix 2013-05-06 22:22:22 -04:00
Franck Joncourt
a9a143a85d Merge remote-tracking branch 'upstream/master' 2013-05-06 11:52:35 +02:00
Franck Joncourt
d4577ab697 Added new tests to the test suite to validate the --save-rc-stanza command line argument. 2013-05-06 11:49:16 +02:00
Franck Joncourt
b3cbf1ecfa Replaced printf() by log_msg(). 2013-05-06 10:02:02 +02:00
Michael Rash
eb143db9a7 [client] added --get-hmac-key to mirror --get-key, closes #68 2013-05-05 21:54:07 -04:00
Michael Rash
83493a424c Merge branch 'master' of github.com:mrash/fwknop 2013-05-05 21:01:26 -04:00
Michael Rash
314cc3eb23 Merge remote-tracking branch 'origin/win32_fixes'
This fixes issue #69 thanks to Damien.
2013-05-05 20:59:04 -04:00
Damien S. Stuart
0363a2099a Regenerated the client and server manpage .in files from the asciidoc sources 2013-05-05 20:44:47 -04:00
Damien S. Stuart
63fed301b8 Merge branch 'win32_fixes' of ssh://github.com/mrash/fwknop into win32_fixes 2013-05-05 20:37:02 -04:00
Damien S. Stuart
2c1a911a50 Copied the win32 Visual Studio solution and project files to preserve a VS 2008 version. 2013-05-05 20:36:33 -04:00
Damien Stuart
c0c0941d55 Tweaked WIN32 conditional for using inet_ntoa instead of inet_ntop to apply only to versions below Vista (WINVER <= 0x0600) 2013-05-05 19:02:48 -04:00
Damien Stuart
b84415c33c Use inet_aton on Windows (Older windows versions do not have enet_ntop). 2013-05-05 16:37:18 -04:00
Franck Joncourt
327257ef5f Fixed command line arguments (key-base64-rijndael and key-base64-hmac).
The cmd_opts structure containing the command line args does not follow the
documentation. This update fix it.
2013-05-05 22:03:21 +02:00
Franck Joncourt
ea8a9419ed Added force-stanza to the client documentation. 2013-05-05 22:00:02 +02:00
Franck Joncourt
f3da685348 Merge remote-tracking branch 'upstream/master' 2013-05-05 21:47:21 +02:00
Franck Joncourt
17a105fd8a Added GPG_SIGNER and GPG_RECIPIENT to the list of important variables. 2013-05-05 21:43:31 +02:00
Franck Joncourt
b8145f6d7f Added --force-stanza command line arg to avoid prompting the user. 2013-05-05 21:13:26 +02:00
Damien Stuart
15d9c6197b Fixes to get hmac_support and 2.5 changes working for the Windows lib and client builds. 2013-05-05 13:20:20 -04:00
Michael Rash
3c3283992c (Franck Joncourt) patch to address sprintf() warnings for issue #60 2013-05-04 14:16:06 -04:00
Franck Joncourt
9d8d1de60d Ask the user whether he wants to overwrite a variable in the updated rc file or not. 2013-05-04 17:02:02 +02:00
Michael Rash
5804e15859 Merge remote-tracking branch 'ag4ve/master'
(Shawn Wilson) This adds better source IP logging for fwknopd log messages.
Closes #70.
2013-05-04 09:41:27 -04:00
Franck Joncourt
9f43f7a6ff Merge remote-tracking branch 'upstream/master' 2013-05-04 15:34:34 +02:00
Franck Joncourt
f217506234 Fixed names of function for better understanding. 2013-05-04 15:33:03 +02:00
Michael Rash
d61d5b964e [test suite] added Cygwin client compatibility tests 2013-05-03 23:17:24 -04:00
Michael Rash
589a68b97b [test suite] additional iptables init/exit 'no flush' tests 2013-05-03 20:56:05 -04:00
Michael Rash
df5f2d3ac0 [test suite] minor update to not count HMAC OpenSSL tests against non-ascii HMAC keys when the hexkey option is not supported 2013-05-03 20:55:20 -04:00
Shawn Wilson
621e7b1c6d Merge branch 'master' of github.com:ag4ve/fwknop
Pull in forked upstream
2013-05-03 12:28:49 -04:00
Michael Rash
5f06cefb02 [test suite] added check for test script inclusion in Makefile.am 2013-05-03 08:35:24 -04:00
Franck Joncourt
84768dda6f Continued implementing a way to not overwrite KEY.. variables with --save-rc-stanza
mrash/fwknop#67
2013-05-03 13:49:32 +02:00
Michael Rash
c086105eb1 [server] added tests on Linux systems for the iptables FLUSH_IPT_* vars 2013-05-02 22:29:51 -04:00
Michael Rash
2297dfd8c2 [server] minor memory leak bug fix for invalid date processing
Bug fix to ensure to release memory when invalid access stanza dates are set
and fwknopd has to exit.  This leak was caught with the test suite in
--enable-valgrind mode based on the following output:

==31947== 568 bytes in 1 blocks are still reachable in loss record 1 of 1
==31947==    at 0x4C2CD7B: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==31947==    by 0x52EE42A: __fopen_internal (iofopen.c:73)
==31947==    by 0x1116A2: parse_access_file (access.c:909)
==31947==    by 0x10BAD5: main (fwknopd.c:194)
2013-05-02 22:26:21 -04:00
Franck Joncourt
c71ce885be First attempt to not ovewrite some configuration variables with --save-rc-stanza.
At this time it only does not overwrite the KEY and HMAC variable without asking the user
what he wants to do.
2013-05-02 23:58:28 +02:00
Michael Rash
56ef34738e [test suite] add new test files to Makefile.am 2013-05-02 15:08:04 -04:00
Shawn Wilson
9dc1d26d6a fixed more typos 2013-05-01 10:59:48 -04:00
Shawn Wilson
e50d776ff7 correct variable name typo 2013-05-01 10:42:13 -04:00
Shawn Wilson
52e35b735d add ip address to messages where appropriate 2013-05-01 10:31:44 -04:00
Franck Joncourt
23de2d6b5f Removed duplicate variable in the test suite (fake_spoof_ip/spoof_ip). 2013-05-01 15:52:01 +02:00
Franck Joncourt
fca497f0d8 New tests for rc file processing (SPA_SOURCE_PORT, FW_TIMEOUT).
Added spa source port variable to dump_transmit_options() and renamed port
to destination port.
2013-05-01 15:29:17 +02:00
Franck Joncourt
209c0f16da Protocol string is set has const char in fko_protocol_t. 2013-05-01 14:33:35 +02:00
Michael Rash
0f24877762 [test suite] minor comment addition so this isn't a zero-byte file 2013-05-01 08:21:11 -04:00
Franck Joncourt
d93648cf99 Moved/Created proto_intostr() and proto_strtoint() to utils.c.
This allows to update dump_transmit_options() to use the log module to dump data.
2013-04-30 22:22:03 +02:00