158 Commits

Author SHA1 Message Date
Michael Rash
96bbf7e61a [client] bug fix to separate out --named-config vs. --no-save-args command line args 2013-05-18 22:36:13 -04:00
Michael Rash
731ca0e038 [client] added warning in --verbose mode if -s is used instead of -a or -R 2013-05-18 10:51:49 -04:00
Franck Joncourt
cee5807deb First draft to be able to use stdin as an input for submitting fwknop key.
mrash/fwknop#74
2013-05-18 10:54:44 +02:00
Michael Rash
45244114f8 [client] --key-gen bug fix to print keys to stdout 2013-05-17 21:03:16 -04:00
Michael Rash
4e5fb77dd0 Merge remote-tracking branch 'fjoncourt/master'
Merged update from Franck - closes issue #71.
2013-05-13 23:10:26 -04:00
Franck Joncourt
9dbb62ae1e Merge remote-tracking branch 'upstream/master' 2013-05-13 16:30:27 +02:00
Franck Joncourt
160c21d6b6 Rewrite enc_mode_inttostr() and enc_mode_strtoint().
Make sure both functions works the same way and refer to the same
encryption mode string.

Updated the fwknop usage message to display the encryption mode.
2013-05-12 16:52:52 +02:00
Michael Rash
add518016c [client] removed unnecessary array NULL check found by Coverity 2013-05-09 22:10:38 -04:00
Michael Rash
8c09d38941 various sizeof() usage and type bug fixes found by Coverity 2013-05-09 21:17:27 -04:00
Michael Rash
9f9bbcbcdd fixed several resource leak conditions found by Coverity 2013-05-09 17:15:58 -04:00
Michael Rash
e1c6f04ef9 [client] fix missing 'break' in switch statement (discovered by Coverity) 2013-05-07 21:43:38 -04:00
Franck Joncourt
a9a143a85d Merge remote-tracking branch 'upstream/master' 2013-05-06 11:52:35 +02:00
Michael Rash
eb143db9a7 [client] added --get-hmac-key to mirror --get-key, closes #68 2013-05-05 21:54:07 -04:00
Franck Joncourt
17a105fd8a Added GPG_SIGNER and GPG_RECIPIENT to the list of important variables. 2013-05-05 21:43:31 +02:00
Franck Joncourt
b8145f6d7f Added --force-stanza command line arg to avoid prompting the user. 2013-05-05 21:13:26 +02:00
Franck Joncourt
9d8d1de60d Ask the user whether he wants to overwrite a variable in the updated rc file or not. 2013-05-04 17:02:02 +02:00
Franck Joncourt
f217506234 Fixed names of function for better understanding. 2013-05-04 15:33:03 +02:00
Franck Joncourt
84768dda6f Continued implementing a way to not overwrite KEY.. variables with --save-rc-stanza
mrash/fwknop#67
2013-05-03 13:49:32 +02:00
Franck Joncourt
c71ce885be First attempt to not ovewrite some configuration variables with --save-rc-stanza.
At this time it only does not overwrite the KEY and HMAC variable without asking the user
what he wants to do.
2013-05-02 23:58:28 +02:00
Franck Joncourt
d93648cf99 Moved/Created proto_intostr() and proto_strtoint() to utils.c.
This allows to update dump_transmit_options() to use the log module to dump data.
2013-04-30 22:22:03 +02:00
Franck Joncourt
10a4e1f675 Updated the TParam typedef to conform to the fko_cli_options_t typedef. 2013-04-30 15:37:08 +02:00
Franck Joncourt
2110790a30 Added new rc file processing tests for the SPA_SERVER_PORT. 2013-04-30 13:54:58 +02:00
Michael Rash
90175250e5 [client] add USE_HMAC handling to parse_rc_param() 2013-04-29 22:14:39 -04:00
Michael Rash
df5066447d Started on --save-rc-stanza tests, client bug fix for HMAC verification in --test mode 2013-04-29 21:43:21 -04:00
Michael Rash
b719c06769 [client] ensure to set HMAC mode by default only when an HMAC key is used 2013-04-28 21:51:16 -04:00
Michael Rash
dd05975217 Merge remote-tracking branch 'fjoncourt/master'
This merges changes from Franck Joncourt for issues #55 (log module for fwknop)
and #64 (hostname resolution not working for -P icmp spoofing).
2013-04-27 22:26:38 -04:00
Franck Joncourt
6063679c6d Continue implementing the log_msg module. 2013-04-27 22:19:40 +02:00
Michael Rash
b3f55bf1ab Convert most strlcpy() calls to use destination bound from sizeof()
This commit helps to ensure correctness of strlcpy() calls in support of fixing
issue #2.
2013-04-27 15:08:11 -04:00
Franck Joncourt
2396193e06 Replaced all references to *fprintf(stderr,* by log_msg() in config_init.c 2013-04-26 17:16:05 +02:00
Franck Joncourt
65d0517a9c Inverted log level enumeration 2013-04-26 16:18:08 +02:00
Franck Joncourt
bf889f7b6e Used args enumeration for both the update_rc() and add_rc_param().
Updated fwknop client to refer to the fwknop args enumeration rather
than the config variable names directly. This should make easier to
handle future changes of the variable name.

New function to validate a string matches a YES pattern in the configuration
file : is_yes_str().

The parse_rc_param() only returns at the end of the function, unless a fatal
error has been encountered.
2013-04-25 23:03:02 +02:00
Michael Rash
f0036f7f22 [client] set HMAC mode whenever any HMAC option is given, add --key-hmac arg 2013-04-20 11:12:04 -04:00
Michael Rash
6b845cce43 remove execute bit 2013-03-23 08:53:48 -04:00
Franck Joncourt
4b63181387 Updated fwknop documentation. 2013-03-20 22:31:58 +01:00
Franck Joncourt
b6bd8a8e8c Fixed issue when trying to save options for a new stanza. 2013-03-20 21:38:52 +01:00
Franck Joncourt
d8090a8143 Allowed an fwknoprc stanza (-n) to be overriden by arguments from the command line.
Added a sanity check to make sure the -n option is used with the --save-rc-stanza option.
2013-03-18 22:06:31 +01:00
Michael Rash
c7b5611fa4 Merge remote-tracking branch 'fjoncourt/hmac_support' into hmac_support
Significant merge from Franck Joncourt to add the ability to save command line
args to ~/.fwknoprc stanzas.  This merge is in support of #4.

Conflicts:
	lib/fko_util.c
	lib/fko_util.h
2013-03-17 21:34:23 -04:00
Franck Joncourt
b9046df64d Remove useless comment. 2013-03-14 22:39:36 +01:00
Franck Joncourt
212075094c Added the possibility to parse only sedction in a fwknoprc file and
not only the whole file - more.
2013-03-14 22:16:37 +01:00
Franck Joncourt
366536055f Added the possibility to parse only sedction in a fwknoprc file and not only the whole file 2013-03-13 07:13:50 +01:00
Michael Rash
70c17be916 added MAX_B64_KEY_LEN for full length SHA512 keys 2013-03-11 22:50:02 -04:00
Franck Joncourt
977ee18c3f New function bool_to_yesno. 2013-03-10 20:55:19 +01:00
Franck Joncourt
8a2bc732b7 Fixed data format for some arguments in fwknoprc when they are saved. 2013-03-10 18:17:08 +01:00
Franck Joncourt
c5163fcc24 Added new parameters HMAC_DIGEST_TYPE to the save capability. 2013-03-09 12:39:05 +01:00
Franck Joncourt
c2ef7f224a Moved static functions from the client to the fko_util.c file. 2013-03-09 12:17:17 +01:00
Franck Joncourt
469f9a5f39 Merge remote-tracking branch 'upstream/hmac_support' into hmac_support
Conflicts:
	client/cmd_opts.h
	client/config_init.c
2013-03-09 11:54:45 +01:00
Michael Rash
44d05a6916 interim commit for supporting multiple HMAC digest types (# 45) 2013-03-07 23:14:48 -05:00
Franck Joncourt
053db37c0d Added more command line switches in order for the user to be able to specify the Rijndael, Rijndael base64 and HMAC key. 2013-03-05 21:01:38 +01:00
Franck Joncourt
38a803fb71 * Added KEY, KEY_BASE64 and HMAC_KEY_BASE64 definitions to the save capability.
* Allowed section to be found during an update of fwknoprc even if there are somes spaces before the stanza.
* Allowed the user to strike the ENTER key to overwrite the section as it will be done with the 'Y' char.
2013-03-03 18:41:31 +01:00
Michael Rash
ffcb77552b Remove lib/fko.h dependency on rijndael.h 2013-02-28 21:47:43 -05:00