Michael Rash
666d150aff
[client] make close() on socket handle more intuitive (resolves 'double close' bugs flagged by Coverity)
2014-07-22 22:04:44 -04:00
Michael Rash
7df1186c66
fixed several socket handle leaks under error conditions spotted by Coverity
2014-07-22 11:30:33 -04:00
Michael Rash
9e990c9be0
fix header non-ascii chars, and introduce test suite support for detecting this in source files
2014-03-14 09:14:35 -04:00
Michael Rash
bfdbb8f260
Updated authorship and copyright information
...
This commit updates all authorship and copyright information to include a
standard header that references the AUTHORS and CREDITS file. This standard
header was written by the Debian legal team at the request of Franck Joncourt.
2014-03-04 17:53:10 -05:00
Franck Joncourt
c2e1a00154
s/GNU Public/GNU General Public/g
2013-06-30 22:21:22 +02:00
Michael Rash
68acbaadc4
remove newline chars from log_msg() calls
2013-06-19 23:42:58 -04:00
Michael Rash
382099e85a
Updated copyright dates, removed NEWS file in favor of the ChangeLog
2013-06-02 14:07:01 -04:00
Michael Rash
52462e7dba
Use {0} initializer for all stack allocated char arrays
...
Lots of places in the code were already using {0} to initialize stack char
arrays, but memset() was being used as well. This commit removes all
unnecessary memset() calls against char arrays that are already initialized
via {0} (which sets all members to zero for such arrays).
2013-05-21 22:00:15 -04:00
Michael Rash
3c3283992c
(Franck Joncourt) patch to address sprintf() warnings for issue #60
2013-05-04 14:16:06 -04:00
Franck Joncourt
7a719389ca
Integrated the log module in the whol client source code.
...
perror() is also replaced by log_msg()
2013-04-29 22:18:29 +02:00
Michael Rash
b3f55bf1ab
Convert most strlcpy() calls to use destination bound from sizeof()
...
This commit helps to ensure correctness of strlcpy() calls in support of fixing
issue #2 .
2013-04-27 15:08:11 -04:00
Michael Rash
e4689892ef
[client] minor http resolve update to include URL in error output
2013-03-19 21:09:11 -04:00
Michael Rash
a413c6cf94
Continue atoi() replacement with strtol() wrapper, closes issue #21
...
This commit completes the conversion to the strtol() wrapper function in order
to remove all atoi() calls. In addition, variable max values are enforced
using more broadly defined RCHK_* values.
2013-02-19 23:11:01 -05:00
Michael Rash
1afc8db96a
Added strtol_wrapper() libfko utility function for atoi() replacement ( #21 )
...
This commit replaces most atoi() calls (which don't report errors) with a strtol()
wrapper function for stronger string -> integer conversion validation.
2013-02-18 19:32:53 -05:00
Damien Stuart
f499e30900
Tweaks to fix issues with building the lib and client under Windows. Added .fwknop.last support on Windows. Bumped the lib version to 0.0.4. Fixed bug in username detection code. Removed -Werror from AM_INIT_AUTOMAKE which prevented setting of CPPFLAG for the lib build in some circumstances.
2012-11-19 08:43:14 -05:00
Michael Rash
d739331818
implemented a couple of minor stronger bounds checks
2012-08-30 23:38:54 -04:00
Michael Rash
38feb8d7b9
Better --resolve-url handling
...
Chop any trailing '/' char, be more careful about handling incoming large HTTP
responses, print the HTTP request and response in --verbose --verbose mode.
2012-08-17 21:02:24 -04:00
Michael Rash
3af8e4c517
[client] Added cipherdyne.com backup check in -R mode.
...
Added backup check against a cipherdyne.com 'myip' cgi instance in -R mode if
the normal check against cipherdyne.org fails.
2012-08-15 22:49:29 -04:00
Michael Rash
f6ac4484c9
minor memset value update 0 -> 0x0 to conform to other memset() calls
2012-08-05 13:05:30 -04:00
Michael Rash
29512bd8ec
[client] -R http recv() read until close (Jonathan Schulz)
...
Applied patch from Jonathan Schulz to ensure that the fwknop client reads all
data from a remote webserver when resolving the client IP address in -R mode.
Jonathan indicated that some webservers would transfer HTTP headers and data
separately, and a single recv() would therefore fail to get the necessary IP
information.
2012-08-03 21:49:03 -04:00
Michael Rash
7c1db89106
minor white space fix tabs->spaces
2012-08-03 21:30:24 -04:00
Michael Rash
84e036f95b
Change HTTP connection type to 'close' in -R mode
...
Applied patch from Jonathan Schulz to change the HTTP connection type to
'close' for the client in -R mode.
2012-08-01 23:27:34 -04:00
Michael Rash
9b7c1a8ce6
Added FORCE_NAT mode to the access.conf file
...
This commit adds a new configuration variable "FORCE_NAT" to the access.conf
file:
For any valid SPA packet, force the requested connection to be NAT'd
through to the specified (usually internal) IP and port value. This is
useful if there are multiple internal systems running a service such as
SSHD, and you want to give transparent access to only one internal system
for each stanza in the access.conf file. This way, multiple external
users can each directly access only one internal system per SPA key.
This commit also implements a few minor code cleanups.
2011-11-30 20:51:19 -05:00
Michael Rash
87416c0cdf
Replaced all strcpy() calls with strlcpy()
...
OpenBSD especially gives compiler warnings whenever strcpy() is used. All such
calls have been replaced with strlcpy().
2011-09-09 22:09:37 -04:00
Damien Stuart
69f41eb399
Set FD_CLOEXEC on pid file descriptor.
...
Added support for setting the URL for resolving source IP via command-line or the .fwknoprc file.
2011-07-07 08:12:49 -04:00
Michael Rash
ca5f82c067
Removed legacy $Id$ tags from svn
...
$Id$ tags don't really mean anything to git so they have been removed from all
source files.
2011-06-18 20:53:40 -04:00
Damien Stuart
0f6ca00ac4
Updated the GPL blurb at the top of the source files. Added some missing copyright statements (Thanks to Franck Joncourt).
...
git-svn-id: file:///home/mbr/svn/fwknop/trunk@300 510a4753-2344-4c79-9c09-4d669213fbeb
2010-11-13 03:04:36 +00:00
Damien Stuart
3111e5868b
Removed a debug print statement.
...
git-svn-id: file:///home/mbr/svn/fwknop/trunk@268 510a4753-2344-4c79-9c09-4d669213fbeb
2010-07-18 01:56:19 +00:00
Damien Stuart
b0886a1d49
Updates and clean-up to address the many compiler warnings when compiled with -Wall. Also some autoconf updates
...
git-svn-id: file:///home/mbr/svn/fwknop/trunk@265 510a4753-2344-4c79-9c09-4d669213fbeb
2010-07-16 14:28:32 +00:00
Damien Stuart
5035cf0fed
Added .fwknoprc file creation and processing. This allows for saved default and named configuration profiles. Updated fwknop manpage to reflect the new capability. Also cleaned up messages (errors, info) from the program.
...
git-svn-id: file:///home/mbr/svn/fwknop/trunk@234 510a4753-2344-4c79-9c09-4d669213fbeb
2010-07-05 22:49:03 +00:00
Michael Rash
510702dc18
added Id tag expansion
...
git-svn-id: file:///home/mbr/svn/fwknop/trunk@180 510a4753-2344-4c79-9c09-4d669213fbeb
2010-01-03 04:49:51 +00:00
Damien Stuart
eaa179a6c1
Changed http_resolve_host code to make it work with or without trailing whitespace in returned content. Updated the IP address format and value checking code. Switched back to whatsmyip.com as default IP resolver.
...
git-svn-id: file:///home/mbr/svn/fwknop/trunk@132 510a4753-2344-4c79-9c09-4d669213fbeb
2009-08-11 01:40:47 +00:00
Damien Stuart
08aa1ef2e8
Updates to accommodate the Windows build.
...
git-svn-id: file:///home/mbr/svn/fwknop/trunk@131 510a4753-2344-4c79-9c09-4d669213fbeb
2009-08-09 17:14:08 +00:00
Damien Stuart
53b7fae8bb
Major rearrangement. Renamed directories: "fko" to "lib", "src" to "client". Added "common" and "server" directories. Setup autoconf to allow disabling the server and/or client builds.
...
git-svn-id: file:///home/mbr/svn/fwknop/trunk@127 510a4753-2344-4c79-9c09-4d669213fbeb
2009-08-09 15:43:16 +00:00