From acdf15f158c32bb12b141ecb8bd37fae5f7bfcb1 Mon Sep 17 00:00:00 2001 From: Michael Rash Date: Wed, 17 Aug 2011 21:24:03 -0400 Subject: [PATCH] Update to force base64 check for all SPA data Previous to this change a check was done for base64 characters in incoming SPA data only up to MIN_SPA_DATA_SIZE. This check may be reinstantiated for SPA packets that are delivered over HTTP (and the packet data is embedded within a URL that may also contain non-base64 chars), but in the meantime the fwknopd daemon should not accept SPA packets over arbitrary ports with any non-base64 chars. --- server/incoming_spa.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/server/incoming_spa.c b/server/incoming_spa.c index 467fb18a..d89795b5 100644 --- a/server/incoming_spa.c +++ b/server/incoming_spa.c @@ -112,10 +112,9 @@ preprocess_spa_data(fko_srv_options_t *opts, char *src_ip) else { /* Make sure the data is valid Base64-encoded characters - * (at least the first MIN_SPA_DATA_SIZE bytes). */ ndx = (char *)spa_pkt->packet_data; - for(i=0; i