From a4273d362774fd17c524c5e4e3369c4d2ee39170 Mon Sep 17 00:00:00 2001 From: Jonathan Bennett Date: Thu, 19 May 2016 23:25:01 -0500 Subject: [PATCH] Server: Add extra check for failing firewall cmd --- server/fw_util_firewalld.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/server/fw_util_firewalld.c b/server/fw_util_firewalld.c index 997643d4..2800edef 100644 --- a/server/fw_util_firewalld.c +++ b/server/fw_util_firewalld.c @@ -348,6 +348,11 @@ comment_match_exists(const fko_srv_options_t * const opts) res = run_extcmd(cmd_buf, err_buf, CMD_BUFSIZE, WANT_STDERR, NO_TIMEOUT, &pid_status, opts); chop_newline(err_buf); + if((!EXTCMD_IS_SUCCESS(res)) || (pid_status != 0)) { + log_msg(LOG_ERR, "comment_match_exists() Error %i from cmd:'%s': %s", + res, cmd_buf, cmd_out); + return 0; /* Errored out*/ + } log_msg(LOG_DEBUG, "comment_match_exists() CMD: '%s' (res: %d, err: %s)", cmd_buf, res, err_buf);