DeforaNetworks/fwknop
DeforaNetworks/fwknop
3
0
Fork 0
Code Releases Activity

Removes a dead code path in client

Browse Source 
A trio of checks were done two places, and the code path always went through both checks.
Since the program announced a fail and closed, the second set of checks could never be triggered.
This commit is contained in:
Jonathan Bennett 2016-05-26 09:32:26 -05:00
parent d804ba33f5
commit 74d3515218
1 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
client/config_init.c
View File

@ -1793,28 +1793,6 @@ update_rc(fko_cli_options_t *options, fko_var_bitmask_t *bitmask)
static void static void
validate_options(fko_cli_options_t *options) validate_options(fko_cli_options_t *options)
{ {
if(options->no_rc_file)
{
if(options->save_rc_stanza)
{
log_msg(LOG_VERBOSITY_ERROR,
"Cannot save an rc stanza in --no-rc-file mode.");
exit(EXIT_FAILURE);
}
if (options->use_rc_stanza[0] != 0x0)
{
log_msg(LOG_VERBOSITY_ERROR,
"Cannot set stanza name in --no-rc-file mode.");
exit(EXIT_FAILURE);
}
if (options->stanza_list)
{
log_msg(LOG_VERBOSITY_ERROR,
"Cannot list stanzas in --no-rc-file mode.");
exit(EXIT_FAILURE);
}
}
if ( (options->use_rc_stanza[0] != 0x0) if ( (options->use_rc_stanza[0] != 0x0)
&& (options->got_named_stanza == 0) && (options->got_named_stanza == 0)
&& (options->save_rc_stanza == 0) ) && (options->save_rc_stanza == 0) )