From c5c58ee6a57c5d8a2418ea78c6d8f08cddf1c282 Mon Sep 17 00:00:00 2001 From: Michael Rash Date: Fri, 26 Feb 2016 20:53:07 -0500 Subject: [PATCH] [server] bug fix for cmd open/close cycle to stop access.conf processing upon first successful match --- ChangeLog | 5 +++++ server/cmd_cycle.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index ef89d11c..19b95fcd 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,4 +1,9 @@ fwknop-2.6.9 (01//2016): + - Bug fix in command open/close cycle feature to ensure that the first + successful match on a valid incoming SPA packet finishes all access.conf + stanza processing. That is, no other stanzas should be looked at after + the first match, and this is consistent with other SPA modes (such as + basic access requests). This bug was reported by Jonathan Bennett. fwknop-2.6.8 (12/23/2015): - [server] Added a major new feature that allows fwknopd to easily diff --git a/server/cmd_cycle.c b/server/cmd_cycle.c index ddfb47f0..366f7094 100644 --- a/server/cmd_cycle.c +++ b/server/cmd_cycle.c @@ -302,7 +302,7 @@ cmd_cycle_open(fko_srv_options_t *opts, acc_stanza_t *acc, if(! add_cmd_close(opts, acc, spadat, stanza_num)) return 0; - return FKO_SUCCESS; + return 1; } static void