DeforaNetworks/fwknop
DeforaNetworks/fwknop
3
0
Fork 0
Code Releases Activity

[server] bug fix in --disable-file-cache mode

Browse Source 
Applied patch from Vlad Glagolev to fix ndbm/gdbm usage when --disable-file-cache
is used for the autoconf configure script.  This functionality was broken in
be4193d734850fe60f14a26b547525ea0b9ce1e9 through improper handling of #define
macros from --disable-file-cache.
This commit is contained in:
Michael Rash 2012-09-10 21:47:48 -04:00
parent 7bd0da29c4
commit 591416e23b
3 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
CREDITS
View File

@ -66,3 +66,9 @@ Fernando Arnaboldi (IOActive)
- Found several conditions in which the server did not properly throw out - Found several conditions in which the server did not properly throw out
maliciously constructed variables in the access.conf file. This has been maliciously constructed variables in the access.conf file. This has been
fixed along with new fuzzing tests in the test suite. fixed along with new fuzzing tests in the test suite.
Vlad Glagolev
- Submitted a patch to fix ndbm/gdbm usage when --disable-file-cache is
used for the autoconf configure script. This functionality was broken in
be4193d734850fe60f14a26b547525ea0b9ce1e9 through improper handling of
#define macros from --disable-file-cache.

6
ChangeLog
View File

@ -1,3 +1,9 @@
fwknop-2.0.4 (09/20/2012):
- [server] (Vlad Glagolev) Submitted a patch to fix ndbm/gdbm usage when
--disable-file-cache is used for the autoconf configure script. This
functionality was broken in be4193d734850fe60f14a26b547525ea0b9ce1e9
through improper handling of #define macros from --disable-file-cache.
fwknop-2.0.3 (09/03/2012): fwknop-2.0.3 (09/03/2012):
- [server] Fernando Arnaboldi from IOActive found several DoS/code - [server] Fernando Arnaboldi from IOActive found several DoS/code
execution vulnerabilities for malicious fwknop clients that manage to execution vulnerabilities for malicious fwknop clients that manage to

10
server/replay_cache.c
View File

@ -138,7 +138,6 @@ replay_warning(fko_srv_options_t *opts, digest_cache_info_t *digest_info)
char created[DATE_LEN]; char created[DATE_LEN];
#if ! USE_FILE_CACHE #if ! USE_FILE_CACHE
char last_ip[INET_ADDRSTRLEN+1] = {0};
char first[DATE_LEN], last[DATE_LEN]; char first[DATE_LEN], last[DATE_LEN];
#endif #endif
@ -375,9 +374,10 @@ replay_db_cache_init(fko_srv_options_t *opts)
GDBM_FILE rpdb; GDBM_FILE rpdb;
#elif HAVE_LIBNDBM #elif HAVE_LIBNDBM
DBM *rpdb; DBM *rpdb;
datum db_ent;
#endif #endif
datum db_key, db_ent, db_next_key; datum db_key, db_next_key;
int db_count = 0; int db_count = 0;
#ifdef HAVE_LIBGDBM #ifdef HAVE_LIBGDBM
@ -565,11 +565,8 @@ is_replay_dbm_cache(fko_srv_options_t *opts, char *digest)
#endif #endif
datum db_key, db_ent; datum db_key, db_ent;
char *digest = NULL;
int digest_len, res = SPA_MSG_SUCCESS; int digest_len, res = SPA_MSG_SUCCESS;
digest_cache_info_t dc_info;
digest_len = strlen(digest); digest_len = strlen(digest);
db_key.dptr = digest; db_key.dptr = digest;
@ -638,7 +635,6 @@ add_replay_dbm_cache(fko_srv_options_t *opts, char *digest)
#endif #endif
datum db_key, db_ent; datum db_key, db_ent;
char *digest = NULL;
int digest_len, res = SPA_MSG_SUCCESS; int digest_len, res = SPA_MSG_SUCCESS;
digest_cache_info_t dc_info; digest_cache_info_t dc_info;
@ -705,7 +701,7 @@ add_replay_dbm_cache(fko_srv_options_t *opts, char *digest)
return(res); return(res);
#endif /* NO_DIGEST_CACHE */ #endif /* NO_DIGEST_CACHE */
}
#endif /* USE_FILE_CACHE */ #endif /* USE_FILE_CACHE */
#if USE_FILE_CACHE #if USE_FILE_CACHE