[libfko] removed fko_new_strdup() fault injection tag since fko_destroy() isn't called

lib/fko_funcs.c

@@ -60,10 +60,6 @@ fko_new(fko_ctx_t *r_ctx)
     */
     ctx->initval = FKO_CTX_INITIALIZED;
 
-#if HAVE_LIBFIU
-    fiu_return_on("fko_new_strdup", FKO_ERROR_MEMORY_ALLOCATION);
-#endif
-
     /* Set the version string.
     */
     ver = strdup(FKO_PROTOCOL_VERSION);

test/fko-wrapper/fko_fault_injection.c

@@ -6,7 +6,6 @@
 
 const char *fiu_tags[] = {
     "fko_new_calloc",
-    "fko_new_strdup",
     "fko_set_rand_value_init",
     "fko_set_rand_value_lenval",
     "fko_set_rand_value_strdup",
@@ -29,7 +28,6 @@ const char *fiu_tags[] = {
     "fko_set_spa_message_type_val"
 };
 const int fiu_rvs[] = {
-    FKO_ERROR_MEMORY_ALLOCATION,
     FKO_ERROR_MEMORY_ALLOCATION,
     FKO_ERROR_CTX_NOT_INITIALIZED,
     FKO_ERROR_INVALID_DATA_RAND_LEN_VALIDFAIL,
@@ -70,6 +68,7 @@ int main(void) {
         else
             printf("[+] fko_new(): %s\n", fko_errstr(res));
         fko_destroy(ctx);
+        ctx = NULL;
 
         fiu_disable(fiu_tags[i]);
     }

test/tests/fault_injection.pl

@@ -125,15 +125,6 @@
             "--fault-injection-tag fko_new_calloc",
         'positive_output_matches' => [qr/Unable to allocate memory/]
     },
-    {
-        'category' => 'fault injection',
-        'subcategory' => 'client',
-        'detail' => 'tag fko_new_strdup',
-        'function' => \&fault_injection_tag,
-        'cmdline'  => "$default_client_hmac_args " .
-            "--fault-injection-tag fko_new_strdup",
-        'positive_output_matches' => [qr/Unable to allocate memory/]
-    },
     {
         'category' => 'fault injection',
         'subcategory' => 'client',