From aa0d92637638503f0fa302a73db12aaa359d9d9c Mon Sep 17 00:00:00 2001 From: Jonathan Bennett Date: Tue, 19 Apr 2016 14:14:51 -0500 Subject: [PATCH 1/2] Removes non-ascii characters from sha3.c Opted to simply remove the umlat from the author's name, and spelled out the greek letters that were in the comments. --- lib/sha3.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/sha3.c b/lib/sha3.c index 9760905f..b4950092 100644 --- a/lib/sha3.c +++ b/lib/sha3.c @@ -6,7 +6,7 @@ /* Implementation by the Keccak, Keyak and Ketje Teams, namely, Guido Bertoni, -Joan Daemen, Michaël Peeters, Gilles Van Assche and Ronny Van Keer, hereby +Joan Daemen, Michael Peeters, Gilles Van Assche and Ronny Van Keer, hereby denoted as "the implementer". For more information, feedback or questions, please refer to our websites: @@ -227,27 +227,27 @@ void KeccakF1600_StatePermute(void *state) UINT8 LFSRstate = 0x01; for(round=0; round<24; round++) { - { // === θ step (see [Keccak Reference, Section 2.3.2]) === + { // === Theta step (see [Keccak Reference, Section 2.3.2]) === tKeccakLane C[5], D; // Compute the parity of the columns for(x=0; x<5; x++) C[x] = readLane(x, 0) ^ readLane(x, 1) ^ readLane(x, 2) ^ readLane(x, 3) ^ readLane(x, 4); for(x=0; x<5; x++) { - // Compute the θ effect for a given column + // Compute the theta effect for a given column D = C[(x+4)%5] ^ ROL64(C[(x+1)%5], 1); - // Add the θ effect to the whole column + // Add the theta effect to the whole column for (y=0; y<5; y++) XORLane(x, y, D); } } - { // === ρ and π steps (see [Keccak Reference, Sections 2.3.3 and 2.3.4]) === + { // === rho and pi steps (see [Keccak Reference, Sections 2.3.3 and 2.3.4]) === tKeccakLane current, temp; // Start at coordinates (1 0) x = 1; y = 0; current = readLane(x, y); - // Iterate over ((0 1)(2 3))^t * (1 0) for 0 ≤ t ≤ 23 + // Iterate over ((0 1)(2 3))^t * (1 0) for 0 <= t <= 23 for(t=0; t<24; t++) { // Compute the rotation constant r = (t+1)(t+2)/2 unsigned int r = ((t+1)*(t+2)/2)%64; @@ -260,19 +260,19 @@ void KeccakF1600_StatePermute(void *state) } } - { // === χ step (see [Keccak Reference, Section 2.3.1]) === + { // === chi step (see [Keccak Reference, Section 2.3.1]) === tKeccakLane temp[5]; for(y=0; y<5; y++) { // Take a copy of the plane for(x=0; x<5; x++) temp[x] = readLane(x, y); - // Compute χ on the plane + // Compute chi on the plane for(x=0; x<5; x++) writeLane(x, y, temp[x] ^((~temp[(x+1)%5]) & temp[(x+2)%5])); } } - { // === ι step (see [Keccak Reference, Section 2.3.5]) === + { // === iota step (see [Keccak Reference, Section 2.3.5]) === for(j=0; j<7; j++) { unsigned int bitPosition = (1< Date: Tue, 19 Apr 2016 14:48:03 -0500 Subject: [PATCH 2/2] Increases a delay value in the test suite The test suite was consistently showing the "exit upon down interface" as failing. The 1 second delay was not enough time for my machine to completely close fwknopd, resulting in the false positive. --- test/test-fwknop.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test-fwknop.pl b/test/test-fwknop.pl index 5ecb4ff1..a9e816dc 100755 --- a/test/test-fwknop.pl +++ b/test/test-fwknop.pl @@ -5796,7 +5796,7 @@ sub down_interface() { &start_fwknopd($test_hr); &run_cmd("$ifconfig_path lo down", $cmd_out_tmp, $curr_test_file); - sleep 1; + sleep 5; &run_cmd("$ifconfig_path lo up", $cmd_out_tmp, $curr_test_file); if (&is_fwknopd_running()) {