DeforaNetworks/fwknop
3
0
Fork 0
Code Releases Activity

Added strtol_wrapper() libfko utility function for atoi() replacement (#21)

Browse Source 
This commit replaces most atoi() calls (which don't report errors) with a strtol()
wrapper function for stronger string -> integer conversion validation.
This commit is contained in:
Michael Rash
2013-02-18 19:32:53 -05:00
parent 934e676053
commit 1afc8db96a
15 changed files with 285 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
server/tcp_server.c
View File

@@ -56,14 +56,21 @@ run_tcp_server(fko_srv_options_t *opts)
{
pid_t pid, ppid;
int s_sock, c_sock, sfd_flags, clen, selval;
int reuse_addr = 1;
int reuse_addr = 1, is_err;
fd_set sfd_set;
struct sockaddr_in saddr, caddr;
struct timeval tv;
char sipbuf[MAX_IPV4_STR_LEN];
unsigned short port = atoi(opts->config[CONF_TCPSERV_PORT]);
unsigned short port;
port = strtol_wrapper(opts->config[CONF_TCPSERV_PORT],
0, MAX_PORT, NO_EXIT_UPON_ERR, &is_err);
if(is_err != FKO_SUCCESS)
{
log_msg(LOG_ERR, "[*] Invalid max TCPSERV_PORT value.\n");
exit(EXIT_FAILURE);
}
log_msg(LOG_INFO, "Kicking off TCP server to listen on port %i.", port);
/* Fork off a child process to run the command and provide its outputs.