This is to allow front-end to properly handle ID values. This change was done to keep consistent with what we were doing before. Alternative version would be to have a sepparate struct on the rest package.
195 lines
4.4 KiB
Go
195 lines
4.4 KiB
Go
package rest
|
|
|
|
import (
|
|
"context"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/cortezaproject/corteza/server/pkg/actionlog"
|
|
"github.com/cortezaproject/corteza/server/pkg/filter"
|
|
pkgid "github.com/cortezaproject/corteza/server/pkg/id"
|
|
"github.com/cortezaproject/corteza/server/store"
|
|
"github.com/cortezaproject/corteza/server/system/rest/request"
|
|
"github.com/cortezaproject/corteza/server/system/service"
|
|
"github.com/cortezaproject/corteza/server/system/types"
|
|
"github.com/go-oauth2/oauth2/v4/errors"
|
|
)
|
|
|
|
type (
|
|
Actionlog struct {
|
|
actionSvc actionlog.Recorder
|
|
store store.Users
|
|
ac interface {
|
|
CanReadActionLog(ctx context.Context) bool
|
|
}
|
|
}
|
|
|
|
// Extend actionlog.Action so we can
|
|
// provide user's email
|
|
actionlogActionPayload struct {
|
|
*actionlog.Action
|
|
Actor string `json:"actor,omitempty"`
|
|
Meta map[string]interface{} `json:"meta,omitempty"`
|
|
}
|
|
|
|
actionlogPayload struct {
|
|
Filter actionlog.Filter `json:"filter"`
|
|
Set []*actionlogActionPayload `json:"set"`
|
|
}
|
|
)
|
|
|
|
func (Actionlog) New() *Actionlog {
|
|
return &Actionlog{
|
|
actionSvc: service.DefaultActionlog,
|
|
ac: service.DefaultAccessControl,
|
|
store: service.DefaultStore,
|
|
}
|
|
}
|
|
|
|
func (ctrl *Actionlog) List(ctx context.Context, r *request.ActionlogList) (interface{}, error) {
|
|
if !ctrl.ac.CanReadActionLog(ctx) {
|
|
return nil, errors.ErrAccessDenied
|
|
}
|
|
|
|
var (
|
|
err error
|
|
f = actionlog.Filter{
|
|
FromTimestamp: r.From,
|
|
ToTimestamp: r.To,
|
|
BeforeActionID: r.BeforeActionID,
|
|
ActorID: r.ActorID,
|
|
Resource: r.Resource,
|
|
Action: r.Action,
|
|
Limit: r.Limit,
|
|
}
|
|
)
|
|
|
|
ee, f, err := ctrl.actionSvc.Find(ctx, f)
|
|
|
|
return ctrl.makeFilterPayload(ctx, ee, f, err)
|
|
}
|
|
|
|
func (ctrl Actionlog) makeFilterPayload(ctx context.Context, ee []*actionlog.Action, f actionlog.Filter, err error) (*actionlogPayload, error) {
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var (
|
|
pp = make([]*actionlogActionPayload, len(ee))
|
|
)
|
|
|
|
// Remap events to payload structs
|
|
for e := range ee {
|
|
pp[e] = &actionlogActionPayload{Action: ee[e]}
|
|
pp[e].Meta = ee[e].Meta
|
|
|
|
sanitizeMapStringInterface(pp[e].Meta)
|
|
}
|
|
|
|
err = userPreloader(
|
|
ctx,
|
|
ctrl.store,
|
|
func(c chan uint64) {
|
|
for e := range ee {
|
|
c <- ee[e].ActorID
|
|
}
|
|
|
|
close(c)
|
|
},
|
|
types.UserFilter{
|
|
Deleted: filter.StateInclusive,
|
|
Suspended: filter.StateInclusive,
|
|
},
|
|
func(u *types.User) error {
|
|
for p := range pp {
|
|
if pp[p].ActorID == u.ID {
|
|
pp[p].Actor = u.Name
|
|
if pp[p].Actor == "" {
|
|
pp[p].Actor = u.Email
|
|
}
|
|
}
|
|
}
|
|
|
|
return nil
|
|
},
|
|
)
|
|
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return &actionlogPayload{Filter: f, Set: pp}, nil
|
|
}
|
|
|
|
// Making sure JS can read old entries that were encoded
|
|
// as numeric. When decoded from the JSON stored in the DB
|
|
// they are of type float64. We'll cast them and store as uint64
|
|
//
|
|
// We do not want to do that to any numeric values just for the keys ending with
|
|
// "ID" or "By"
|
|
func sanitizeMapStringInterface(m map[string]interface{}) {
|
|
for k := range m {
|
|
switch v := m[k].(type) {
|
|
case float64:
|
|
if strings.HasSuffix(k, "ID") || strings.HasSuffix(k, "By") {
|
|
// make sure uint64 values on fields ending with ID
|
|
// are properly encoded as strings
|
|
m[k] = strconv.FormatUint(uint64(v), 10)
|
|
}
|
|
|
|
case map[string]interface{}:
|
|
sanitizeMapStringInterface(v)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Preloader collects all ids of users, loads them and sets them back
|
|
//
|
|
// We'll be accessing the store directly since this is protected with action-log.read operation check.
|
|
//
|
|
// @todo move action log collection and user merging to dedicated service
|
|
func userPreloader(ctx context.Context, s store.Users, g func(chan uint64), f types.UserFilter, collect func(*types.User) error) error {
|
|
var (
|
|
// channel that will collect the IDs in the getter
|
|
ch = make(chan uint64, 0)
|
|
|
|
// unique index for IDs
|
|
unq = make(map[uint64]bool)
|
|
)
|
|
|
|
// Reset the collection of the IDs
|
|
f.UserID = make([]string, 0)
|
|
|
|
// Call getter and collect the IDs
|
|
go g(ch)
|
|
|
|
rangeLoop:
|
|
for {
|
|
select {
|
|
case <-ctx.Done():
|
|
close(ch)
|
|
break rangeLoop
|
|
case id, ok := <-ch:
|
|
if !ok {
|
|
// Channel closed
|
|
break rangeLoop
|
|
}
|
|
|
|
if !unq[id] {
|
|
unq[id] = true
|
|
f.UserID = append(f.UserID, pkgid.String(id))
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
// Load all users (even if deleted, suspended) from the given list of IDs
|
|
uu, _, err := store.SearchUsers(ctx, s, f)
|
|
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return uu.Walk(collect)
|
|
}
|