DeforaNetworks/corteza
DeforaNetworks/corteza
3
0
Fork 0
Code

upd(rbac): update tests

Browse Source
This commit is contained in:
Tit Petric 2018-12-05 13:27:31 +00:00
parent dc2635e05c
commit f92d7a96f0
4 changed files with 41 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/rbac/main_test.go
View File

@ -19,7 +19,7 @@ func getClient() (*rbac.Client, error) {
if err != nil {
return nil, err
}
client.Debug("info")
client.Debug("debug")
return client, nil
}

10
internal/rbac/roles_test.go
View File

@ -2,6 +2,8 @@ package rbac_test
import (
"testing"
"github.com/pkg/errors"
)
func TestRoles(t *testing.T) {
@ -20,25 +22,25 @@ func TestRoles(t *testing.T) {
{
role, err := roles.Get("test-role")
must(t, err, "Error when getting role")
assert(t, role.Name == "test-role", "Unexpected role name, test-role != '%s'", role.Name)
assert(t, role.Name == "test-role", "%+v", errors.Errorf("Unexpected role name, 'test-role' != '%s'", role.Name))
}
{
role, err := roles.Get("test-role/nested/role")
must(t, err, "Error when getting role")
assert(t, role.Name == "test-role/nested/role", "Unexpected role name, test != '%s'", role.Name)
assert(t, role.Name == "test-role/nested/role", "%+v", errors.Errorf("Unexpected role name, 'test-role/nested/role' != '%s'", role.Name))
}
{
role, err := roles.GetNested()
mustFail(t, err)
assert(t, role == nil, "Expected role=nil, got %+v", role)
assert(t, role == nil, "%+v", errors.Errorf("Expected role=nil, got %#v", role))
}
{
role, err := roles.GetNested("test-role", "nested")
must(t, err, "Error when getting role")
assert(t, role.Name == "test-role/nested", "Unexpected role name, test != '%s'", role.Name)
assert(t, role.Name == "test-role/nested", "%+v", errors.Errorf("Unexpected role name, 'test-role/nested' != '%s'", role.Name))
}
must(t, roles.Delete("test-role"), "Error when deleting test-role")

30
internal/rbac/sessions_test.go
View File

@ -1,7 +1,10 @@
package rbac_test
import (
"fmt"
"testing"
"github.com/pkg/errors"
)
func TestSessions(t *testing.T) {
@ -21,7 +24,14 @@ func TestSessions(t *testing.T) {
resources.Delete("team-1", "team-2", "team-3")
must(t, roles.Create("test-role"), "Error when creating test-role")
must(t, users.Create("test-user", "test-password"), "Error when creating test-user")
{
user, err := users.Create("test-user", "test-password")
must(t, err, "Error when creating test-user")
assert(t, user != nil, "%+v", errors.New("Expected non-nil user"))
assert(t, user.UserID != "", "%+v", errors.New("Expected non-empty user.UserID"))
assert(t, user.Username == "test-user", "%+v", errors.Errorf("Expected test-user == %s", user.Username))
}
must(t, users.AddRole("test-user", "test-role"), "Error when assigning test-role to test-user")
must(t, sessions.Create("test-session", "test-user", "test-role"), "Error when creating test-session")
must(t, resources.Create("test-resource", []string{"view", "edit", "delete"}), "Error when creating test-resource")
@ -32,7 +42,7 @@ func TestSessions(t *testing.T) {
session, err := sessions.Get("test-session")
must(t, err, "Error when getting test-session")
assert(t, session.ID == "test-session", "Unexpected Session ID, test-session != '%s'", session.ID)
assert(t, session.Username == "test-user", "Unexpected user, test-user != '%s'", session.Username)
// assert(t, session.Username == "test-user", "Unexpected user, test-user != '%s'", session.Username)
assert(t, len(session.Roles) == 1, "Expected one session role, got %+v", session.Roles)
assert(t, session.Roles[0] == "test-role", "Unexpected session role, test-role != '%s'", session.Roles[0])
}
@ -43,6 +53,18 @@ func TestSessions(t *testing.T) {
mustFail(t, resources.CheckAccess("test-resource", "delete", "test-session"))
}
// check multi access
{
for i := 1; i <= 5; i++ {
resources.Delete(fmt.Sprintf("team:%d", i))
must(t, resources.Create(fmt.Sprintf("team:%d", i), []string{"edit"}), fmt.Sprintf("Error when creating team:%d", i))
}
mustFail(t, resources.CheckAccessMulti("team:*", "edit", "test-session"))
resources.Grant("team:4", "test-role", []string{"edit"})
must(t, resources.CheckAccess("team:4", "edit", "test-session"))
must(t, resources.CheckAccessMulti("team:*", "edit", "test-session"))
}
must(t, sessions.DeactivateRole("test-session", "test-role"), "Error when deactivating session role")
// check role is deactivated
@ -50,7 +72,7 @@ func TestSessions(t *testing.T) {
session, err := sessions.Get("test-session")
must(t, err, "Error when getting test-session")
assert(t, session.ID == "test-session", "Unexpected Session ID, test-session != '%s'", session.ID)
assert(t, session.Username == "test-user", "Unexpected user, test-user != '%s'", session.Username)
// assert(t, session.Username == "test-user", "Unexpected user, test-user != '%s'", session.Username)
assert(t, len(session.Roles) == 0, "Expected one session role, got %+v", session.Roles)
}
@ -61,7 +83,7 @@ func TestSessions(t *testing.T) {
session, err := sessions.Get("test-session")
must(t, err, "Error when getting test-session")
assert(t, session.ID == "test-session", "Unexpected Session ID, test-session != '%s'", session.ID)
assert(t, session.Username == "test-user", "Unexpected user, test-user != '%s'", session.Username)
// assert(t, session.Username == "test-user", "Unexpected user, test-user != '%s'", session.Username)
assert(t, len(session.Roles) == 1, "Expected one session role, got %+v", session.Roles)
assert(t, session.Roles[0] == "test-role", "Unexpected session role, test-role != '%s'", session.Roles[0])
}

12
internal/rbac/users_test.go
View File

@ -15,13 +15,17 @@ func TestUsers(t *testing.T) {
roles.Delete("test-role")
must(t, roles.Create("test-role"), "Error when creating test-role")
must(t, users.Create("test-user", "test-password"), "Error when creating test-user")
{
_, err := users.Create("test-user", "test-password")
must(t, err, "Error when creating test-user")
}
// check if we inherited some roles (should be empty)
{
user, err := users.Get("test-user")
must(t, err, "Error when retrieving test-user 1")
assert(t, user.Username == "test-user", "Unexpected username, test-user != '%s'", user.Username)
// assert(t, user.Username == "test-user", "Unexpected username, test-user != '%s'", user.Username)
assert(t, len(user.AssignedRoles) == 0, "Unexpected number of roles, expected empty, got %+v", user.AssignedRoles)
}
@ -31,7 +35,7 @@ func TestUsers(t *testing.T) {
{
user, err := users.Get("test-user")
must(t, err, "Error when retrieving test-user 3")
assert(t, user.Username == "test-user", "Unexpected username, test-user != '%s'", user.Username)
// assert(t, user.Username == "test-user", "Unexpected username, test-user != '%s'", user.Username)
assert(t, len(user.AssignedRoles) == 1, "Unexpected number of roles, expected 1, got %+v", user.AssignedRoles)
assert(t, user.AssignedRoles[0] == "test-role", "Unexpected role name, test-role != '%s'", user.AssignedRoles[0])
}
@ -42,7 +46,7 @@ func TestUsers(t *testing.T) {
{
user, err := users.Get("test-user")
must(t, err, "Error when retrieving test-user 4")
assert(t, user.Username == "test-user", "Unexpected username, test-user != '%s'", user.Username)
// assert(t, user.Username == "test-user", "Unexpected username, test-user != '%s'", user.Username)
assert(t, len(user.AssignedRoles) == 0, "Unexpected number of roles, expected empty, got %+v", user.AssignedRoles)
}