From e56ede6035a3b79885bcb61fb5c630be0f42c746 Mon Sep 17 00:00:00 2001 From: Tit Petric Date: Tue, 5 Feb 2019 16:13:15 +0100 Subject: [PATCH] fix(crm): prevent variable shadowing for new --- crm/service/record.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/crm/service/record.go b/crm/service/record.go index 9edaaab6a..eb6dc16db 100644 --- a/crm/service/record.go +++ b/crm/service/record.go @@ -114,26 +114,26 @@ func (svc *record) Find(moduleID uint64, filter, sort string, page, perPage int) } -func (svc *record) Create(new *types.Record) (record *types.Record, err error) { +func (svc *record) Create(in *types.Record) (record *types.Record, err error) { var module *types.Module err = svc.db.Transaction(func() (err error) { - if module, err = svc.moduleRepo.FindByID(new.ModuleID); err != nil { + if module, err = svc.moduleRepo.FindByID(in.ModuleID); err != nil { return } - if err = svc.sanitizeValues(module, new.Values); err != nil { + if err = svc.sanitizeValues(module, in.Values); err != nil { return } - new.OwnedBy = auth.GetIdentityFromContext(svc.ctx).Identity() - new.CreatedBy = new.OwnedBy - new.CreatedAt = time.Now() - if record, err = svc.repository.Create(new); err != nil { + in.OwnedBy = auth.GetIdentityFromContext(svc.ctx).Identity() + in.CreatedBy = in.OwnedBy + in.CreatedAt = time.Now() + if record, err = svc.repository.Create(in); err != nil { return } - if err = svc.repository.UpdateValues(record.ID, new.Values); err != nil { + if err = svc.repository.UpdateValues(record.ID, in.Values); err != nil { return }