From cb89c9b1a4b903b7980df0385e40184eefe81615 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Toma=C5=BE=20Jerman?= Date: Fri, 2 Feb 2024 09:20:28 +0100 Subject: [PATCH] Remove excessive statechange logging --- server/automation/service/session.go | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/server/automation/service/session.go b/server/automation/service/session.go index b0c533553..676d61e59 100644 --- a/server/automation/service/session.go +++ b/server/automation/service/session.go @@ -448,23 +448,19 @@ func (svc *session) stateChangeHandler(ctx context.Context) wfexec.StateChangeHa svc.mux.Lock() defer svc.mux.Unlock() - log := svc.log.With( - logger.Uint64("sessionID", s.ID()), - zap.Stringer("status", i), - ) - ses := svc.pool[s.ID()] if ses == nil { + log := svc.log.With( + logger.Uint64("sessionID", s.ID()), + zap.Stringer("status", status), + ) + log.Warn("could not find session to update") return } ses.FlushCounter++ - log = log.With(logger.Uint64("workflowID", ses.WorkflowID)) - - log.Debug("state change handler") - var ( // By default, we want to update session when new status is prompted, delayed, completed, canceled or failed // But if status is active, we'll flush it every X frames (sessionStateFlushFrequency) @@ -542,6 +538,11 @@ func (svc *session) stateChangeHandler(ctx context.Context) wfexec.StateChangeHa ses.FlushCounter = 0 ses.CopyRuntimeStacktrace() if err := store.UpsertAutomationSession(ctx, svc.store, ses); err != nil { + log := svc.log.With( + logger.Uint64("sessionID", s.ID()), + zap.Stringer("status", status), + ) + log.Error("failed to update session", zap.Error(err)) } }