Introduce DAL model ident formatter to simplify the interfaces

This commit is contained in:
Tomaž Jerman
2022-05-26 17:41:15 +02:00
parent fb7e9b5ce1
commit a0a6314ea9
6 changed files with 171 additions and 71 deletions
+5 -7
View File
@@ -296,13 +296,11 @@ func (svc *dalConnection) reloadConnections(ctx context.Context) (err error) {
func (svc *dalConnection) makeConnectionMeta(ctx context.Context, c *types.DalConnection) (cm dal.ConnectionMeta, err error) {
// @todo we could probably utilize connection params more here
cm = dal.ConnectionMeta{
ConnectionDefaults: dal.ConnectionDefaults{
ModelIdent: c.Config.DefaultModelIdent,
AttributeIdent: c.Config.DefaultAttributeIdent,
PartitionFormat: c.Config.DefaultPartitionFormat,
},
SensitivityLevel: c.SensitivityLevel,
Label: c.Handle,
DefaultModelIdent: c.Config.DefaultModelIdent,
DefaultAttributeIdent: c.Config.DefaultAttributeIdent,
DefaultPartitionFormat: c.Config.DefaultPartitionFormat,
SensitivityLevel: c.SensitivityLevel,
Label: c.Handle,
}
return
-8
View File
@@ -78,14 +78,6 @@ var (
DalPrimaryConnectionResourceType = "corteza::system:primary_dal_connection"
)
func (c DalConnection) ConnectionDefaults() dal.ConnectionDefaults {
return dal.ConnectionDefaults{
ModelIdent: c.Config.DefaultModelIdent,
AttributeIdent: c.Config.DefaultAttributeIdent,
PartitionFormat: c.Config.DefaultPartitionFormat,
}
}
func (c DalConnection) ActiveCapabilities() capabilities.Set {
return c.Capabilities.Supported.
Union(c.Capabilities.Enforced).