From 9615a9153a6130d7b61710dff204c35689a5d8fd Mon Sep 17 00:00:00 2001
From: Mumbi Francis <kinya.francis.mumbi@gmail.com>
Date: Fri, 16 Jun 2023 14:20:13 +0300
Subject: [PATCH] Redirect user to webapp one upon successful signup

If the authorize client isn't trusted, the user is taken to authorize-client page
---
 .../auth/oauth2-authorize-client.yaml         |  2 +-
 server/app/boot_auth.go                       |  4 ++++
 server/auth/assets/templates/inc_nav.html.tpl | 13 +------------
 server/auth/handlers/handle_signup.go         | 19 +++++++++++++++++--
 server/auth/handlers/links.go                 |  1 +
 5 files changed, 24 insertions(+), 15 deletions(-)

diff --git a/locale/en/corteza-server/auth/oauth2-authorize-client.yaml b/locale/en/corteza-server/auth/oauth2-authorize-client.yaml
index a4077e0b9..a4a618496 100644
--- a/locale/en/corteza-server/auth/oauth2-authorize-client.yaml
+++ b/locale/en/corteza-server/auth/oauth2-authorize-client.yaml
@@ -11,4 +11,4 @@ template:
   errors:
     invalid-user: Cannot continue with unauthorized email, visit <a data-test-id="link-redirect-to-profile" href="{{link}}">your profile</a> and resolve the issue.
 alerts:
-  denied: cannot authorize {{client}}, no permissions
+  denied: 'Failed to authorize {{client}}: insufficient permissions'
diff --git a/server/app/boot_auth.go b/server/app/boot_auth.go
index be957f638..8e2371b76 100644
--- a/server/app/boot_auth.go
+++ b/server/app/boot_auth.go
@@ -39,6 +39,10 @@ func (app *CortezaApp) initAuth(ctx context.Context) (err error) {
 	// set base path for links&routes in auth server
 	authHandlers.BasePath = app.Opt.HTTPServer.BaseUrl
 
+	// set webapp base path in auth server
+	// @todo refactor, consider passing this into the functions that need it instead of setting it globally
+	authHandlers.WebappBasePath = app.Opt.HTTPServer.WebappBaseUrl
+
 	auth.DefaultSigner = auth.HmacSigner(app.Opt.Auth.Secret)
 
 	if auth.HttpTokenVerifier, err = auth.TokenVerifierMiddlewareWithSecretSigner(app.Opt.Auth.Secret); err != nil {
diff --git a/server/auth/assets/templates/inc_nav.html.tpl b/server/auth/assets/templates/inc_nav.html.tpl
index 753460e0c..dee2086f2 100644
--- a/server/auth/assets/templates/inc_nav.html.tpl
+++ b/server/auth/assets/templates/inc_nav.html.tpl
@@ -12,18 +12,7 @@
 {{ $activeNav := default "" .activeNav }}
 
 {{ if not .hideNav }}
-	{{ if and .user .client }}
-	<div class="py-1 px-3">
-		<a
-			data-test-id="link-finalize-authorization"
-			class="text-danger"
-			href="{{ links.OAuth2AuthorizeClient }}"
-		>
-		 {{ tr "inc_nav.template.authorize-client" }} {{ .client.Name }}
-		 <i class="bi bi-chevron-double-right"></i>
-		 </a>
-	</div>
-	{{ else if .user }}
+	{{ if .user }}
 	<ul class="nav ml-1 d-flex justify-content-around">
 		<li class="nav-item {{ if eq $activeNav "profile" }}active{{ end  }}">
 			<a
diff --git a/server/auth/handlers/handle_signup.go b/server/auth/handlers/handle_signup.go
index e0c73b8b1..127965883 100644
--- a/server/auth/handlers/handle_signup.go
+++ b/server/auth/handlers/handle_signup.go
@@ -43,7 +43,17 @@ func (h *AuthHandlers) signupProc(req *request.AuthReq) error {
 				zap.String("email", newUser.Email),
 				logger.Uint64s("roles", newUser.Roles()),
 			)
-			req.RedirectTo = GetLinks().Profile
+
+			// redirect to the webapp base path
+			req.RedirectTo = WebappBasePath
+
+			// if the client is nil, redirect to the profile
+			// else check if the client is trusted
+			if req.Client == nil {
+				req.RedirectTo = GetLinks().Profile
+			} else if !req.Client.Trusted {
+				req.RedirectTo = GetLinks().OAuth2AuthorizeClient
+			}
 
 			req.AuthUser = request.NewAuthUser(h.Settings, newUser, false)
 
@@ -115,7 +125,12 @@ func (h *AuthHandlers) confirmEmail(req *request.AuthReq) (err error) {
 				Text: t("signup.alerts.email-confirmed-logged-in"),
 			})
 
-			req.RedirectTo = GetLinks().Profile
+			// redirect to the webapp base path
+			req.RedirectTo = WebappBasePath
+
+			if req.Client != nil && !req.Client.Trusted {
+				req.RedirectTo = GetLinks().OAuth2AuthorizeClient
+			}
 
 			req.AuthUser = request.NewAuthUser(h.Settings, user, false)
 
diff --git a/server/auth/handlers/links.go b/server/auth/handlers/links.go
index 657e9de3a..a2bea50c6 100644
--- a/server/auth/handlers/links.go
+++ b/server/auth/handlers/links.go
@@ -58,6 +58,7 @@ var (
 	invalidLinkChars        = regexp.MustCompile(`[^-A-Za-z0-9+&@#/%?=~_|!:,.;\\(\\)]`)
 	stripSchema             = regexp.MustCompile(`(.*\/\/)`)
 	BasePath         string = "/"
+	WebappBasePath   string = "/"
 )
 
 func GetLinks() Links {