Implement access control for resource translation management

pkg/codegen-v3/assets/templates/gocode/locale/service.go.tpl

@@ -12,6 +12,7 @@ import (
 
 	"github.com/cortezaproject/corteza-server/pkg/actionlog"
 	intAuth "github.com/cortezaproject/corteza-server/pkg/auth"
+	"github.com/cortezaproject/corteza-server/pkg/errors"
 	"github.com/cortezaproject/corteza-server/pkg/locale"
 	"github.com/cortezaproject/corteza-server/store"
 	systemTypes "github.com/cortezaproject/corteza-server/system/types"
@@ -26,7 +27,7 @@ type (
 	}
 
 	localeAccessController interface {
-		// CanManageResourceTranslation(context.Context) bool
+		CanManageResourceTranslations(context.Context) bool
 	}
 
 	ResourceTranslationsManagerService interface {
@@ -39,6 +40,8 @@ type (
 	}
 )
 
+var ErrNotAllowedToManageResourceTranslations = errors.Unauthorized("not allowed to manage resource translations")
+
 func ResourceTranslationsManager(ls locale.Resource) *resourceTranslationsManager {
 	return &resourceTranslationsManager{
 		actionlog: DefaultActionlog,
@@ -49,10 +52,15 @@ func ResourceTranslationsManager(ls locale.Resource) *resourceTranslationsManage
 }
 
 func (svc resourceTranslationsManager) Upsert(ctx context.Context, rr locale.ResourceTranslationSet) (err error) {
-	// @todo AC
-	//if (!svc.ac.CanManageResourceTranslation(ctx)) {
-	//	return *****ErrNotAllowedToCreate()
-	//}
+	// User is allowed to manage resource translations when:
+	//  - managed resource translation strings are all for default language
+	//  or
+	//  - user is allowed to manage resource translations
+	if rr.ContainsForeign(svc.Locale().Default().Tag) {
+		if !svc.ac.CanManageResourceTranslations(ctx) {
+			return ErrNotAllowedToManageResourceTranslations
+		}
+	}
 
 	// @todo validation
 

pkg/locale/resource.go

@@ -23,11 +23,25 @@ func ContentID(cID uint64, i int) uint64 {
 }
 
 func (rr ResourceTranslationSet) SetLanguage(tag language.Tag) {
+	str := tag.String()
 	for _, r := range rr {
-		r.Lang = tag.String()
+		r.Lang = str
 	}
 }
 
+// Returns true if resource translation set  contains foreign (non-native) languages
+func (rr ResourceTranslationSet) ContainsForeign(native language.Tag) bool {
+	str := native.String()
+
+	for _, r := range rr {
+		if r.Lang != str {
+			return true
+		}
+	}
+
+	return false
+}
+
 func (rx ResourceTranslationIndex) FindByKey(k string) *ResourceTranslation {
 	return rx[k]
 }

pkg/locale/service.go

@@ -31,6 +31,7 @@ type (
 		TResourceFor(tag language.Tag, ns, key string, rr ...string) string
 		Tags() []language.Tag
 		ResourceTranslations(code language.Tag, resource string) ResourceTranslationIndex
+		Default() *Language
 	}
 
 	service struct {