From 8f3c9d72eb448b2e618839adef426b1187a37b63 Mon Sep 17 00:00:00 2001 From: Denis Arh Date: Thu, 27 Jun 2019 15:54:50 +0200 Subject: [PATCH] Allow page reorder on root We require page creation permissions to reorder on root --- compose/internal/service/page.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/compose/internal/service/page.go b/compose/internal/service/page.go index a9459e232..551293338 100644 --- a/compose/internal/service/page.go +++ b/compose/internal/service/page.go @@ -173,6 +173,11 @@ func (svc page) filterPageSetByPermission(pp types.PageSet, f types.PageFilter, func (svc page) Reorder(namespaceID, selfID uint64, pageIDs []uint64) error { if ns, err := svc.loadNamespace(namespaceID); err != nil { return err + } else if selfID == 0 { + // Reordering on root mode + if !svc.ac.CanCreatePage(svc.ctx, ns) { + return ErrNoUpdatePermissions.withStack() + } } else if p, err := svc.checkPermissions(svc.pageRepo.FindByID(ns.ID, selfID)); err != nil { return err } else if !svc.ac.CanUpdatePage(svc.ctx, p) {