DeforaNetworks/corteza
DeforaNetworks/corteza
3
0
Fork 0
Code

Tweak UI recovery process in case a workflow step panics

Browse Source
This commit is contained in:
Tomaž Jerman 2023-01-13 11:54:45 +01:00
parent 6c08e0b45b
commit 80d9c58fb5
1 changed files with 40 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

66
client/web/workflow/src/components/WorkflowEditor.vue
View File

@ -2185,39 +2185,53 @@ export default {
this.toastInfo(this.$t('notification:started-test'), this.$t('notification:test-in-progress')) this.toastInfo(this.$t('notification:started-test'), this.$t('notification:test-in-progress'))
await this.$AutomationAPI.workflowExec(testParams) await this.$AutomationAPI.workflowExec(testParams)
.then(({ sessionID }) => { .then(({ sessionID, error: wfExecErr }) => {
this.dryRun.sessionID = sessionID this.dryRun.sessionID = sessionID
this.redrawLabel(this.graph.model.getCell(this.dryRun.cellID).mxObjectId) this.redrawLabel(this.graph.model.getCell(this.dryRun.cellID).mxObjectId)
const sessionHandler = ({ completedAt, status, stacktrace, error = false }) => {
if (completedAt) {
// If stacktrace exists, render it
if (stacktrace) {
this.renderTrace(testParams.stepID, stacktrace)
if (status === 'completed') {
this.toastSuccess(this.$t('notification:workflow-test-completed'), this.$t('notification:test-completed'))
}
}
// Reset state and refresh the trigger label so spinner disappears
this.dryRun.lookup = true
this.dryRun.processing = false
this.dryRun.sessionID = undefined
this.redrawLabel(this.graph.model.getCell(this.dryRun.cellID).mxObjectId)
// If error or no stacktrace, raise an error/warning
if (error) {
throw new Error(error)
} else if (!stacktrace) {
this.toastWarning(this.$t('notification:trace-unavailable'), this.$t('notification:test-completed'))
}
} else {
setTimeout(sessionReader, 1000)
}
}
// Check if session is completed/failed every second // Check if session is completed/failed every second
const sessionReader = () => { const sessionReader = () => {
this.$AutomationAPI.sessionRead({ sessionID }) this.$AutomationAPI.sessionRead({ sessionID })
.then(({ completedAt, status, stacktrace, error = false }) => { .then(sessionHandler)
if (completedAt) { .catch(err => {
// If stacktrace exists, render it // In case of a workflow step crashing, the session may not always be available
if (stacktrace) { //
this.renderTrace(testParams.stepID, stacktrace) // In this case, if the wf exec raises an error and the session is not found,
// make a dummy session so the UI is able to recover without needing to
if (status === 'completed') { // refresh the page.
this.toastSuccess(this.$t('notification:workflow-test-completed'), this.$t('notification:test-completed')) if (wfExecErr && err.meta && err.meta.resource === 'automation:session' && err.meta.type === 'notFound') {
} sessionHandler({ completedAt: new Date(), status: 'failed', error: wfExecErr })
} return
// Reset state and refresh the trigger label so spinner disappears
this.dryRun.lookup = true
this.dryRun.processing = false
this.dryRun.sessionID = undefined
this.redrawLabel(this.graph.model.getCell(this.dryRun.cellID).mxObjectId)
// If error or no stacktrace, raise an error/warning
if (error) {
throw new Error(error)
} else if (!stacktrace) {
this.toastWarning(this.$t('notification:trace-unavailable'), this.$t('notification:test-completed'))
}
} else {
setTimeout(sessionReader, 1000)
} }
throw err
}).catch(this.toastErrorHandler(this.$t('notification:failed-test'))) }).catch(this.toastErrorHandler(this.$t('notification:failed-test')))
} }