DeforaNetworks/corteza
DeforaNetworks/corteza
3
0
Fork 0
Code

Call coredor (via gRPC) with independent context & timeout

Browse Source 
Reusing context caused random case of context cancelation
on server side and "illegal buffer" error on corredor
This commit is contained in:
Denis Arh 2020-03-12 18:56:04 +01:00
parent 7fbd4eab30
commit 700fae5e00
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/corredor/service.go
View File

@ -502,6 +502,8 @@ func (svc *service) registerTriggers(script *ServerScript) []uintptr {
// individual event implemntation
func (svc service) exec(ctx context.Context, script string, runAs string, event Event) (err error) {
var (
requestId = middleware.GetReqID(ctx)
rsp *ExecResponse
invoker auth.Identifiable
@ -604,13 +606,19 @@ func (svc service) exec(ctx context.Context, script string, runAs string, event
// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// ////
ctx, cancel := context.WithTimeout(ctx, svc.opt.DefaultExecTimeout)
ctx, cancel := context.WithTimeout(
// We need a new, independent context here
// to be sure this is executed safely & fully
// without any outside interfeance (cancellation, timeouts)
context.Background(),
svc.opt.DefaultExecTimeout,
)
defer cancel()
// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// ////
ctx = metadata.NewOutgoingContext(ctx, metadata.MD{
"x-request-id": []string{middleware.GetReqID(ctx)},
"x-request-id": []string{requestId},
})
// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// //// ////