From 63fb63f98068e29c7c7576332e2c7728a9782137 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Toma=C5=BE=20Jerman?= <tomaz.jerman121@gmail.com>
Date: Fri, 6 Jan 2023 15:52:47 +0100
Subject: [PATCH] Fix improper revision history display for multi value fields

Issues:
* The first value was repeatted and last was omitted (index lapsus)
* If a value was removed, it was also not shown in the old version
---
 .../src/components/PageBlocks/RecordRevisionsBase.vue     | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/client/web/compose/src/components/PageBlocks/RecordRevisionsBase.vue b/client/web/compose/src/components/PageBlocks/RecordRevisionsBase.vue
index 606d1d25f..4ca963f45 100644
--- a/client/web/compose/src/components/PageBlocks/RecordRevisionsBase.vue
+++ b/client/web/compose/src/components/PageBlocks/RecordRevisionsBase.vue
@@ -67,18 +67,18 @@
                 :key="change.key"
               >
                 <b-tr>
-                  <b-td :rowspan="change.new.length">
+                  <b-td :rowspan="Math.max(change.new ? change.new.length : 0, change.old ? change.old.length : 0)">
                     {{ change.key }}
                   </b-td>
                   <b-td>{{ change.old ? change.old[0] : '-' }}</b-td>
                   <b-td>{{ change.new ? change.new[0] : '-' }}</b-td>
                 </b-tr>
                 <b-tr
-                  v-for="(val, index) in change.new.slice(1)"
+                  v-for="index in Math.max(change.new ? change.new.length - 1 : 0, change.old ? change.old.length - 1 : 0)"
                   :key="change.key + index"
                 >
-                  <b-td>{{ change.old ? change.old[index]: '-' }}</b-td>
-                  <b-td>{{ change.new ? change.new[index]: '-' }}</b-td>
+                  <b-td>{{ change.old && change.old.length > index ? change.old[index]: '-' }}</b-td>
+                  <b-td>{{ change.new && change.new.length > index ? change.new[index]: '-' }}</b-td>
                 </b-tr>
               </b-tbody>
             </b-table-simple>