Fix handler/request codegens

Missing return caused malformed response output:
{"error":{"message":"invalid username/password combination"}}{"response":false}

Remove param logging when params.Fill() returns an error
This commit is contained in:
Denis Arh
2019-05-28 10:51:56 +02:00
parent 22476933f4
commit 5c750fb7cf
29 changed files with 427 additions and 147 deletions
+3 -1
View File
@@ -35,14 +35,16 @@ func New{name|expose}(h {name|expose}API) *{name|expose} {
defer r.Body.Close()
params := request.New{name|capitalize}{call.name|capitalize}()
if err := params.Fill(r); err != nil {
logger.LogParamError("{name|expose}.{call.name|capitalize}", r, err, params.Auditable())
logger.LogParamError("{name|expose}.{call.name|capitalize}", r, err)
resputil.JSON(w, err)
return
}
value, err := h.{call.name|capitalize}(r.Context(), params)
if err != nil {
logger.LogControllerError("{name|expose}.{call.name|capitalize}", r, err, params.Auditable())
resputil.JSON(w, err)
return
}
logger.LogControllerCall("{name|expose}.{call.name|capitalize}", r, params.Auditable())
if !serveHTTP(value, w, r) {