From 3fda882b75b8697528d7b62ba8b94a6239103d8f Mon Sep 17 00:00:00 2001 From: Peter Grlica Date: Fri, 11 Dec 2020 21:36:35 +0100 Subject: [PATCH] Node acl check fix --- federation/service/node.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/federation/service/node.go b/federation/service/node.go index c4c7e9c6c..1a663f566 100644 --- a/federation/service/node.go +++ b/federation/service/node.go @@ -438,7 +438,7 @@ func (svc node) updater(ctx context.Context, nodeID uint64, action func(...*node func (svc node) FindBySharedNodeID(ctx context.Context, sharedNodeID uint64) (*types.Node, error) { n, err := svc.store.LookupFederationNodeBySharedNodeID(ctx, sharedNodeID) - if !svc.ac.CanManageNode(ctx, n) { + if n != nil && !svc.ac.CanManageNode(ctx, n) { return nil, NodeErrNotAllowedToManage() } @@ -448,7 +448,7 @@ func (svc node) FindBySharedNodeID(ctx context.Context, sharedNodeID uint64) (*t func (svc node) FindByID(ctx context.Context, nodeID uint64) (*types.Node, error) { n, err := svc.store.LookupFederationNodeByID(ctx, nodeID) - if !svc.ac.CanManageNode(ctx, n) { + if n != nil && !svc.ac.CanManageNode(ctx, n) { return nil, NodeErrNotAllowedToManage() }