From 39905c17883713342e8aa0f7b7ce5043e5d350d0 Mon Sep 17 00:00:00 2001 From: Vivek Patel Date: Tue, 29 Nov 2022 20:04:35 +0530 Subject: [PATCH] Add WEEK ref to GVal expr reference It helps to define the outputType of week ql reference --- server/pkg/dal/runner_gval.go | 8 +++++++- server/store/adapters/rdbms/drivers/postgres/ql.go | 5 ++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/server/pkg/dal/runner_gval.go b/server/pkg/dal/runner_gval.go index b3e9118a7..683dff7de 100644 --- a/server/pkg/dal/runner_gval.go +++ b/server/pkg/dal/runner_gval.go @@ -94,7 +94,7 @@ var ( OutType: &TypeBoolean{}, }, "ge": { - //Handler: makeGenericCompHandler(">="), + // Handler: makeGenericCompHandler(">="), Handler: func(args ...string) string { return fmt.Sprintf("%s >= %s", args[0], args[1]) }, @@ -213,6 +213,12 @@ var ( }, OutType: &TypeNumber{}, }, + "week": { + Handler: func(args ...string) string { + return fmt.Sprintf("week(%s)", args[0]) + }, + OutType: &TypeNumber{}, + }, "date_format": { Handler: func(args ...string) string { return fmt.Sprintf("strftime(%s, %s)", args[0], args[1]) diff --git a/server/store/adapters/rdbms/drivers/postgres/ql.go b/server/store/adapters/rdbms/drivers/postgres/ql.go index cb194506f..b27ee14fd 100644 --- a/server/store/adapters/rdbms/drivers/postgres/ql.go +++ b/server/store/adapters/rdbms/drivers/postgres/ql.go @@ -68,9 +68,8 @@ var ( }, "week": { Handler: func(args ...exp.Expression) exp.Expression { - return exp.NewSQLFunctionExpression("TO_CHAR", - exp.NewLiteralExpression("?::TIMESTAMPTZ", args[0]), - exp.NewLiteralExpression("?", "IW"), + return exp.NewSQLFunctionExpression("EXTRACT", + exp.NewLiteralExpression("WEEK FROM ?", args[0]), ) }, },