From 33c6f30a19d423a35ad8123a5d68ebb359f9298c Mon Sep 17 00:00:00 2001 From: Denis Arh Date: Sat, 29 Aug 2020 16:06:26 +0200 Subject: [PATCH] Add missing rows.Close() on reporting building --- compose/repository/record.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/compose/repository/record.go b/compose/repository/record.go index 67648eac1..d314b3601 100644 --- a/compose/repository/record.go +++ b/compose/repository/record.go @@ -116,10 +116,15 @@ func (r record) Report(module *types.Module, metrics, dimensions, filter string) } else if rows, err := r.db().Query(query, args...); err != nil { return nil, errors.Wrapf(err, "can not execute report query (%s)", query) } else { + defer rows.Close() for rows.Next() { result = append(result, crb.Cast(rows)) } + if err = rows.Err(); err != nil { + return nil, err + } + return result, nil } }